Page MenuHomePhabricator

PHP Fatal error: Cannot override final method Job::getTitle() in SMW
Open, LowPublic

Description

PHP Fatal error: Cannot override final method Job::getTitle() in /www/dev.translatewiki.net/docroot/w/extensions/SemanticMediaWiki/src/MediaWiki/Job.php on line 20

Impact
Anyone running MediaWiki master with SemanticMediaWiki will have a broken wiki. This prevents translatewiki.net from updating code.

Debugging
The method was made final in fc5d51f. CC @Krinkle @aaron @kostajh
Per my understanding this part should be reverted for now and go through the regular deprecation/migration process.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2019, 8:52 AM
Nikerabbit triaged this task as High priority.May 7 2019, 8:56 AM

I'm tempted to triage this as UBN! because it breaks my dev&testing environment and prevents running the "train" on translatewiki.net, but just putting it as high for now since I have a workaround for dev.

I'm not sure both can be supported simultaneously. We can re-allow method overrides, but the value wouldn't be stored. What is it used for?

I didn't check SMW side until now and found https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/3986 – but they haven't had a stable release since then. Perhaps this is acceptable breakage for now.

Ah, I see. They added it as copy of the default so that it would exist even in old MW versions (before MW 1.19). So it wasn't doing anything. Okay, yeah, I think that's fair and not something we need to support in MW 1.34.

Krinkle lowered the priority of this task from High to Low.May 7 2019, 5:57 PM
Krinkle moved this task from Inbox to Radar on the Performance-Team board.
Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.

I'm planning to close this (if I remember) when the fix is included in a stable SMW release.