Page MenuHomePhabricator

Upload zuul_2.5.1-wmf9 to apt.wikimedia.org
Closed, ResolvedPublic

Description

On May 6th 2019, we had two CI incidents both originating from Zuul
https://wikitech.wikimedia.org/wiki/Incident_documentation/20190506-zuul

The first was a layout config change which, although valid, was not properly recognized by Zuul. T105474.
The second is an overflow of the zuul-merger due to preparing merge commits for parent changes even when those merge commits are not needed T140297.

2.5.1wmf8 ported two patches:

https://gerrit.wikimedia.org/r/#/c/integration/zuul/+/508390/patch: Don't call merger for non live item
https://gerrit.wikimedia.org/r/#/c/integration/zuul/+/508511/patch: Fix reject clauses in the absence of approvals

But the first is broken and I have not been able to backport it properly. Hence I have cut a new 2.5.1wmf9 version without that faulty backport:

The new package is at https://people.wikimedia.org/~hashar/debs/zuul_2.5.1-wmf9/

It should be uploaded to apt.wikimedia.org under jessie-wikimedia/main.

Details

Related Gerrit Patches:
integration/zuul : debian/jessie-wikimedia2.5.1-wmf9: drop faulty patch

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2019, 9:31 AM
jbond added a subscriber: jbond.May 7 2019, 10:11 AM

this has been uploaded let me know if there are any issues

jbond closed this task as Resolved.May 7 2019, 10:11 AM

Change 509417 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/zuul@debian/jessie-wikimedia] 2.5.1-wmf9: drop faulty patch

https://gerrit.wikimedia.org/r/509417

hashar reopened this task as Open.May 10 2019, 2:49 PM

Eventually the backport patch for T140297 was wrong. It does not apply from Zuul v3 to the Zuul v2.5.x we are using. So I have rolled it back on production to 2.5.1-wmf7 a few days ago :-( I thought I could properly backport the patch but it is a little bit more complicated than expected and I am giving up for now.

Anyway, I have a cut a new Debian package 2.5.1-wmf9 to drop the faulty patch for T140297 but still have the patch for T105474. And I will upgrade production to that next week.

The new package for jessie-wikimedia/main is at https://people.wikimedia.org/~hashar/debs/zuul_2.5.1-wmf9/

hashar renamed this task from Upload zuul_2.5.1-wmf8 to apt.wikimedia.org to Upload zuul_2.5.1-wmf9 to apt.wikimedia.org.May 10 2019, 2:50 PM
hashar updated the task description. (Show Details)
hashar removed a parent task: Restricted Task.May 10 2019, 2:52 PM
jbond closed this task as Resolved.May 10 2019, 2:57 PM
jbond claimed this task.

latest package has been uploaded re open if further problems

Change 509417 merged by jenkins-bot:
[integration/zuul@debian/jessie-wikimedia] 2.5.1-wmf9: drop faulty patch

https://gerrit.wikimedia.org/r/509417

Upgraded and it seems to work fine. Thank you!