Page MenuHomePhabricator

Create buttons
Closed, ResolvedPublic

Description

Create button components to be used in the IP warning overlay

  • for two modifiers (styling per figma)
    • "normal", $wmui-color-base80 (can probably be the default, i.e. does not really need a modifier in practice)
    • "primary progressive", $color-primary i.e. $wmui-color-accent50
  • message can be set via prop
  • href can be set via prop
  • click event is caught by default and can be listened to by using components by observing @click
  • this, outside of styling, could be identical to what EventEmittingButton already does. Consider refactoring, e.g. move current styles inside of EventEmittingButton into a EventEmittingToolsButton, use the EventEmittingButton inside of it.

Notes:

  • This is our first go at developing the components independently upfront ("into the kitchen sink") and using them later (T222698). Let's see how this works for us.
  • let's go with the ooui terminology

@Hanna_Petruschat_WMDE Are we right assuming that hover and active state for the button should be implemented per the rules established in the wm styleguide?

Event Timeline

Could we please extend the description...it is a bit brief and I guess hardly to understand right way on the first look what is ment and why it is in order on this position.

Change 508778 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Introduce EventEmittingToolsButton Component

https://gerrit.wikimedia.org/r/508778

Change 509440 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] storybook: introduce to allow for upfront component dev

https://gerrit.wikimedia.org/r/509440

Change 509862 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] EventEmittingButton: re-establish rtl support

https://gerrit.wikimedia.org/r/509862

Change 508778 merged by jenkins-bot:
[wikibase/termbox@master] Change EventEmittingButton for mw-styles

https://gerrit.wikimedia.org/r/508778

Change 509440 merged by jenkins-bot:
[wikibase/termbox@master] storybook: introduce to allow for upfront component dev

https://gerrit.wikimedia.org/r/509440

Change 509862 merged by jenkins-bot:
[wikibase/termbox@master] EventEmittingButton: re-establish rtl support

https://gerrit.wikimedia.org/r/509862

Change 510197 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] EventEmittingButton: differentiate framed and framless

https://gerrit.wikimedia.org/r/510197

Change 510197 merged by jenkins-bot:
[wikibase/termbox@master] EventEmittingButton: differentiate framed and frameless

https://gerrit.wikimedia.org/r/510197

Change 510835 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] termbox: use latest

https://gerrit.wikimedia.org/r/510835

Change 510835 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] termbox: use latest

https://gerrit.wikimedia.org/r/510835