Page MenuHomePhabricator
Create Task
Maniphest T222698

Implement IP warning overlay
Closed, ResolvedPublic
Actions

Description

  • get all the messages
  • do not HTML escape the message that contains markup (bold) <- discussion had: sanitize it (to restrict to few useful tags) or not: tough b/c will bloat client artifact. Perhaps we can use the built in mediawiki parser / sanitiser? (https://www.mediawiki.org/wiki/Manual:Messages_API#Format_options)
  • add illustrative asset or find alternative approach
  • add buttons and link
    • "login", looks like button, actual link within same window See: T222692 for building link content
    • "edit without logging", looks like button, closes overlay
    • "create an account", looks like link, actual link within same window See: T222692 for building link content

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+1 -1termbox: use latest
wikibase/termboxmaster+200 -59Add login and sign-up link URLs
wikibase/termboxmaster+38 -3EventEmittingButton: ability to use as a vanilla link
wikibase/termboxmaster+208 -8Wire up the IP warning overlay
mediawiki/extensions/Wikibasemaster+6 -0Add "anonymous edit warning" messages for the new termbox
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pablo-WMDE created this task.May 7 2019, 10:02 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2019, 10:02 AM
• Pablo-WMDE updated the task description. (Show Details)May 7 2019, 10:08 AM
• Pablo-WMDE mentioned this in T222695: Create buttons.May 7 2019, 6:04 PM
Tarrow updated the task description. (Show Details)May 8 2019, 10:33 AM
Tarrow updated the task description. (Show Details)
• Pablo-WMDE assigned this task to Jakob_WMDE.May 13 2019, 9:49 AM
• Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-15 board.
gerritbot added a comment.May 13 2019, 2:14 PM

Change 509853 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Add "anonymous edit warning" messages for the new termbox

https://gerrit.wikimedia.org/r/509853

gerritbot added a project: Patch-For-Review.May 13 2019, 2:14 PM
gerritbot added a comment.May 14 2019, 10:12 AM

Change 510116 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Wire up the IP warning overlay

https://gerrit.wikimedia.org/r/510116

gerritbot added a comment.May 14 2019, 12:26 PM

Change 509853 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add "anonymous edit warning" messages for the new termbox

https://gerrit.wikimedia.org/r/509853

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 14 2019, 1:00 PM
gerritbot added a comment.May 14 2019, 4:01 PM

Change 510191 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Add login and sign-up link URLs

https://gerrit.wikimedia.org/r/510191

gerritbot added a comment.May 15 2019, 10:27 AM

Change 510462 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] EventEmittingButton: ability to use as a vanilla link

https://gerrit.wikimedia.org/r/510462

gerritbot added a comment.May 15 2019, 12:43 PM

Change 510116 merged by jenkins-bot:
[wikibase/termbox@master] Wire up the IP warning overlay

https://gerrit.wikimedia.org/r/510116

gerritbot added a comment.May 15 2019, 12:50 PM

Change 510462 merged by jenkins-bot:
[wikibase/termbox@master] EventEmittingButton: ability to use as a vanilla link

https://gerrit.wikimedia.org/r/510462

Jakob_WMDE removed Jakob_WMDE as the assignee of this task.May 15 2019, 1:11 PM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-15 board.
Jakob_WMDE added a subscriber: Jakob_WMDE.
gerritbot added a comment.May 17 2019, 10:11 AM

Change 510191 merged by jenkins-bot:
[wikibase/termbox@master] Add login and sign-up link URLs

https://gerrit.wikimedia.org/r/510191

gerritbot added a comment.May 17 2019, 10:21 AM

Change 510835 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] termbox: use latest

https://gerrit.wikimedia.org/r/510835

• Pablo-WMDE moved this task from Peer Review to Done on the Wikidata-Termbox-Iteration-15 board.May 17 2019, 10:33 AM
gerritbot added a comment.May 17 2019, 5:30 PM

Change 510835 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] termbox: use latest

https://gerrit.wikimedia.org/r/510835

Ladsgroup removed a project: Patch-For-Review.May 21 2019, 10:09 PM
Jakob_WMDE closed this task as Resolved.May 22 2019, 9:24 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL