Page MenuHomePhabricator

Bump wdio-wikibase version to 1.0.0 and treat it as stable
Closed, ResolvedPublic5 Story Points

Description

Currently, wdio-wikibase has 0 as major version which defines it as "still in initial development". Since we are already using it in production, we might consider treating it as stable and increasing the version number to 1.0.0 as briefly discussed by @alaa_wmde in the context of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/507959

Acceptance Criteria

  • move wdio-wikibase into its own git repo
  • release wdio-wikibase v1.0.0 on npm registry
  • add linting, syntax check in supposedly supported node versions

Event Timeline

Michael created this task.May 7 2019, 10:38 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptMay 7 2019, 10:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore renamed this task from Consider bumping wdio-wikibase version to 1.0.0 and treat it as stable to Bump wdio-wikibase version to 1.0.0 and treat it as stable.Jul 9 2019, 5:25 PM
Addshore triaged this task as Low priority.
Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Addshore moved this task from incoming to consider for next sprint on the Wikidata board.
alaa_wmde updated the task description. (Show Details)Tue, Jul 30, 12:29 PM
alaa_wmde set the point value for this task to 5.

This does not go to production, so it is fine to be on Github.. Though we might want to put it in gerrit if that doesn't not take long to setup.

Change 528214 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Move wdio-wikibase to a dedicated repo

https://gerrit.wikimedia.org/r/528214

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMon, Aug 5, 6:40 PM

Change 528402 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[wikibase/termbox@master] Add "wdio-wikibase": "1.0.0" to dependencies

https://gerrit.wikimedia.org/r/528402

Change 528402 merged by jenkins-bot:
[wikibase/termbox@master] Add "wdio-wikibase": "1.0.0" to dependencies

https://gerrit.wikimedia.org/r/528402

Change 528214 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move wdio-wikibase to a dedicated repo

https://gerrit.wikimedia.org/r/528214

Could we have a (simple is fine) README in https://github.com/wmde/wdio-wikibase?

WMDE-leszek removed Ladsgroup as the assignee of this task.Mon, Aug 12, 10:15 AM
WMDE-leszek removed a project: Patch-For-Review.
WMDE-leszek updated the task description. (Show Details)

Also, is checking in package-lock.json file is the practice we've agreed on at WMDE? It does not seem to be there yet. Finally, having npm test do something would be nice.

Also, is checking in package-lock.json file is the practice we've agreed on at WMDE? It does not seem to be there yet. Finally, having npm test do something would be nice.

I don't know about WMDE-wide decision but basically it's checked in everywhere I looked. Did you find any place that we didn't check in package-lock.json?

Ladsgroup removed Ladsgroup as the assignee of this task.Mon, Aug 12, 12:12 PM

For the rest (README + tests) I give up. I need to leave soon.

WMDE-leszek updated the task description. (Show Details)Tue, Aug 13, 8:27 AM
Pablo-WMDE updated the task description. (Show Details)Tue, Aug 13, 8:33 AM
WMDE-leszek closed this task as Resolved.Thu, Aug 15, 12:32 PM
WMDE-leszek claimed this task.

Now done, kudos to @Pablo-WMDE, @Jakob_WMDE and @noarave for doing the remaining 20%!

WMDE-leszek updated the task description. (Show Details)Thu, Aug 15, 12:32 PM