Maniphest T222722

[Talk Pages Dev] Diffing using SHA
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tsevener
	May 7 2019, 2:38 PM

Tags

Referenced Files

None

Subscribers

Description

Note: This is a subtask for tracking purposes, it should be closed once dev-complete and tested as a part of the parent task.

Perform diffing using SHA from API to only insert / remove new discussions & replies rather than throwing them all out if the revisionID incremented.

See https://github.com/wikimedia/wikipedia-ios/pull/3066#discussion_r279410293

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• JMinor	T215928 MVP for User Talk pages: As an app editor I need to be able to see my User Talk page to get feedback on my edits and communicate with other editors
		Resolved		Tsevener	T222722 [Talk Pages Dev] Diffing using SHA

Event Timeline

Tsevener created this task.May 7 2019, 2:38 PM

• JMinor triaged this task as Medium priority.May 9 2019, 8:38 PM

• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.

Tsevener moved this task from Ready for Development to Doing on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.May 10 2019, 9:46 PM

• JMinor moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.May 13 2019, 7:09 PM

Still need to test for performance so putting this in waiting for now.

• JMinor lowered the priority of this task from Medium to Low.May 28 2019, 6:15 PM

Tsevener moved this task from Blocked or Waiting to Doing on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.Jun 18 2019, 5:59 PM

Tsevener moved this task from Doing to Needs Code Review on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.Jun 21 2019, 10:08 PM

Performance tweak PR - https://github.com/wikimedia/wikipedia-ios/pull/3148

In waiting until we cut a release branch, plan is for it to go into develop for 6.3.1.

• JMinor edited projects, added iOS-app-v6.3.1 Lobster-On-An-ORV; removed iOS-app-v6.3-Lobster-On-A-Motorcycle.Jun 27 2019, 8:04 PM

• JMinor moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v6.3.1 Lobster-On-An-ORV board.Jul 1 2019, 6:39 PM

Tsevener moved this task from Needs Engineering Sync to Needs Code Review on the iOS-app-v6.3.1 Lobster-On-An-ORV board.Jul 9 2019, 6:28 PM

• JMinor moved this task from Needs Code Review to Blocked or Waiting on the iOS-app-v6.3.1 Lobster-On-An-ORV board.Jul 9 2019, 6:28 PM

• JMinor moved this task from Blocked or Waiting to Needs Code Review on the iOS-app-v6.3.1 Lobster-On-An-ORV board.

Tsevener moved this task from Needs Code Review to Doing on the iOS-app-v6.3.1 Lobster-On-An-ORV board.Jul 10 2019, 2:19 PM

Tsevener moved this task from Doing to Needs Code Review on the iOS-app-v6.3.1 Lobster-On-An-ORV board.Jul 10 2019, 9:49 PM

Tsevener closed this task as Resolved.Jul 22 2019, 5:02 PM