Customize query in gerrit
Details
Details
Related Objects
Related Objects
Event Timeline
Comment Actions
Once per instance is probably ok, as it should be rare to have the same video over and over. Uh, except on the file page with versions maybe. >_<
(However it definitely shouldn't fetch anything until requested. Might have to fix upstream, will check.)
Comment Actions
Upstream issue is: https://github.com/videojs/video.js/issues/5252
Looks like it's been stalled for a while (and may need some changes to the moz-vtt.js component which is upstream from video.js), so this might be an opportunity to get it unstuck for them. :D
Comment Actions
Change 516643 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Patch for video.js subtitle loading behavior
Comment Actions
Basic patch added which is an updating of the old upstream PR. Seems to work but might have edge cases; I'm happy to merge it for now to get us rolling if it looks ok.
New upstream PR: https://github.com/videojs/video.js/pull/6043
Comment Actions
Change 516643 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] video.js: Local patch for subtitle loading behavior
Comment Actions
Let's call this Resolved and remember to apply the patch when updating upstream before they merge the patch.
Comment Actions
Change 518167 had a related patch set uploaded (by Jforrester; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.8] video.js: Local patch for subtitle loading behavior
Comment Actions
Change 518167 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.8] video.js: Local patch for subtitle loading behavior
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2019-06-20T23:01:57Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.8/extensions/TimedMediaHandler/resources/videojs/: Latest VideoJS for T222763 (duration: 00m 59s)