Page MenuHomePhabricator

Add error-handling to commons-selection.js
Open, NormalPublic

Description

If MediaWiki API replies with an error, commons-selection.js can't deal with it. The user then sees "Loading..." forever. An error message would do. The error message should recommend disconnecting and reconnecting of Wikimedia account.

Example error reply, happens when user have old OAuth token.

{"error":{"code":"mwoauth-invalid-authorization","info":"The authorization headers in your request are not valid: No approved grant was found for that authorization token.","*":"See https://commons.wikimedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes."},"servedby":"mw1228"}

Event Timeline

Urbanecm created this task.May 8 2019, 11:18 AM
Urbanecm triaged this task as Normal priority.
Urbanecm moved this task from Inbox to Bugs on the WMCZ-Tracker board.

Per IRC.

Change 509637 had a related patch set uploaded (by Shreyasminocha; owner: Shreyasminocha):
[wikimedia-cz/tracker@master] Add error handling to Commons selection interface

https://gerrit.wikimedia.org/r/509637