Page MenuHomePhabricator
Create Task
Maniphest T222831

mw.widgets.TitleWidget should not support interwiki links by default
Closed, ResolvedPublic
Actions

Description

In most contexts (outside the VE link inspector) we don't want to allow the user to enter an interwiki link, but the default code path still does an API request to lookup all the interwiki prefixes, which is just a waste. It also marks interwiki links as valid, when in those contexts they should probably not be.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+1 -0Link inspector: Pass new 'showInterwikis' option to title widget
mediawiki/coremaster+38 -23mw.widgets.TitleWidget: Don't allow interwiki links by default
Customize query in gerrit

Event Timeline

Esanders created this task.May 8 2019, 6:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2019, 6:45 PM
gerritbot added a comment.May 8 2019, 6:49 PM

Change 508890 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] mw.widgets.TitleWidget: Don't allow interwiki links by default

https://gerrit.wikimedia.org/r/508890

gerritbot added a project: Patch-For-Review.May 8 2019, 6:49 PM

Change 508891 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Link inspector: Pass new 'showInterwikis' option to title widget

https://gerrit.wikimedia.org/r/508891

gerritbot added a comment.May 8 2019, 7:34 PM

Change 508890 merged by jenkins-bot:
[mediawiki/core@master] mw.widgets.TitleWidget: Don't allow interwiki links by default

https://gerrit.wikimedia.org/r/508890

gerritbot added a comment.May 8 2019, 7:46 PM

Change 508891 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Link inspector: Pass new 'showInterwikis' option to title widget

https://gerrit.wikimedia.org/r/508891

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).May 8 2019, 8:00 PM
matmarex closed this task as Resolved.May 9 2019, 5:45 PM
matmarex assigned this task to Esanders.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL