Page MenuHomePhabricator

mw.widgets.TitleWidget should not support interwiki links by default
Closed, ResolvedPublic

Description

In most contexts (outside the VE link inspector) we don't want to allow the user to enter an interwiki link, but the default code path still does an API request to lookup all the interwiki prefixes, which is just a waste. It also marks interwiki links as valid, when in those contexts they should probably not be.

Event Timeline

Esanders created this task.May 8 2019, 6:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2019, 6:45 PM

Change 508890 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] mw.widgets.TitleWidget: Don't allow interwiki links by default

https://gerrit.wikimedia.org/r/508890

Change 508891 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Link inspector: Pass new 'showInterwikis' option to title widget

https://gerrit.wikimedia.org/r/508891

Change 508890 merged by jenkins-bot:
[mediawiki/core@master] mw.widgets.TitleWidget: Don't allow interwiki links by default

https://gerrit.wikimedia.org/r/508890

Change 508891 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Link inspector: Pass new 'showInterwikis' option to title widget

https://gerrit.wikimedia.org/r/508891

matmarex closed this task as Resolved.May 9 2019, 5:45 PM
matmarex assigned this task to Esanders.