When the user has already set an email address, we shouldn't display an input to let them change it. We already do the right thing when their email address is set and confirmed, but not when it's set and unconfirmed.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Help panel: Only offer the email input when email address is unset | mediawiki/extensions/GrowthExperiments | master | +118 -87 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 506328 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Help panel: Only offer the email input when email address is unset
Comment Actions
Change 506328 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help panel: Only offer the email input when email address is unset
Comment Actions
Checked in betalabs - all works as exepcted.
@MMiller_WMF - the email field of unconfirmed email becomes non-modifiable from the Help panel (incl the Ask question on Mentorship). The text under the text field is the same as before - "You'll receive an email notificaiton...". I wonder if it's understandable for a user that they still need to confirm their email address.
| present production - unconfirmed email | betalabs - unconfirmed email |
 |  |
Comment Actions
Actually, @Etonkovidova, I just realized that we should double-check the EventLogging. This seems like the sort of change that has the potential to break EventLogging for this part of the workflow. Would you be willing to try that out? To make sure that the correct events continue to come through for these steps?
This comment was removed by Etonkovidova.
Comment Actions
I checked betalabs eventlogging (the most recent timestamp - 20190613141120) for three schemas - HelpPanel, HomepageModule, and HomepageVisit. The change of emails never was actually tracked; the state of the email address is being tracked. I re-checked recorded actions - and there were no discrepancies.