Page MenuHomePhabricator

Don't offer email input in help panel when email address is already set
Closed, ResolvedPublic

Description

When the user has already set an email address, we shouldn't display an input to let them change it. We already do the right thing when their email address is set and confirmed, but not when it's set and unconfirmed.

Event Timeline

Catrope created this task.May 8 2019, 10:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2019, 10:00 PM

Change 506328 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Help panel: Only offer the email input when email address is unset

https://gerrit.wikimedia.org/r/506328

Change 506328 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help panel: Only offer the email input when email address is unset

https://gerrit.wikimedia.org/r/506328

Checked in betalabs - all works as exepcted.

@MMiller_WMF - the email field of unconfirmed email becomes non-modifiable from the Help panel (incl the Ask question on Mentorship). The text under the text field is the same as before - "You'll receive an email notificaiton...". I wonder if it's understandable for a user that they still need to confirm their email address.

present production - unconfirmed emailbetalabs - unconfirmed email
MMiller_WMF closed this task as Resolved.

@Etonkovidova -- your screenshot from beta looks good to me. Thanks.

MMiller_WMF reopened this task as Open.May 9 2019, 10:04 PM

Actually, @Etonkovidova, I just realized that we should double-check the EventLogging. This seems like the sort of change that has the potential to break EventLogging for this part of the workflow. Would you be willing to try that out? To make sure that the correct events continue to come through for these steps?

This comment was removed by Etonkovidova.

@Etonkovidova -- your comment above is blank. Did something get lost?

Etonkovidova closed this task as Resolved.Thu, Jun 13, 2:26 PM

I checked betalabs eventlogging (the most recent timestamp - 20190613141120) for three schemas - HelpPanel, HomepageModule, and HomepageVisit. The change of emails never was actually tracked; the state of the email address is being tracked. I re-checked recorded actions - and there were no discrepancies.