Page MenuHomePhabricator
Create Task
Maniphest T222873

Design behavior when importing an uncategorized file
Closed, ResolvedPublic
Actions

Description

We need to decide what to do when FileImporter is used to import an uncategorized file. Currently, the code will do nothing special, and will happily import the file.

Some behaviors we might want to adopt:

  1. Show a warning box on the preview page when importing, saying "Please consider adding categories after import".
  2. More humble warning stating the above, but without an infobox.
  3. Add a configurable snippet of wikitext to the file info during preview, and during actual import. This could default to empty, but would probably be set to {{subst:unc}} on commonswiki.
  4. Ask for confirmation when importing an uncategorized file, in an additional step.

If we want to replicate UploadWizard functionality, I believe it does (3) and (4).

Related Objects
Search...

Event Timeline

awight created this task.May 9 2019, 10:58 AM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 9 2019, 10:58 AM
awight assigned this task to Lea_WMDE.May 9 2019, 10:59 AM
awight removed a project: WMDE-QWERTY-Sprint-2019-04-30.
thiemowmde moved this task from Backlog to Tickets in preparation/investigation on the Move-Files-To-Commons board.May 14 2019, 1:34 PM
Jan_Dittrich subscribed.May 20 2019, 9:24 AM

I see two problems here:

  • The file-info sections contain many templates making it hard to spot any additions, warnings etc. (one can always 1-up this with popups etc., but it is just escalating the problems)
  • category editing is is, according to experienced editors best done with special tools or gadgets rather than via manual addition in Wikitext. So we could say: "Your file lacks categories" but could not offer a good way to add them (except we want to invest in a upload-wizard-like GUI implementation)

One possibility I see is having a rather humble pointer to it:

image.png (133×722 px, 9 KB)

However, if the file has categories, they would also need to appear there. Currently, they don't:

image.png (83×635 px, 6 KB)

awight added a comment.May 20 2019, 9:28 AM
In T222873#5197156, @Jan_Dittrich wrote:

One possibility I see is having a rather humble pointer to it:

Thanks, I'll add that option to the task description.

However, if the file has categories, they would also need to appear there. Currently, they don't:

FYI, this functionality is pending merge of rEFLI0ac06a4da052.

awight updated the task description. (Show Details)May 20 2019, 9:28 AM
awight mentioned this in T189573: Display current category state on Import Preview Page.May 23 2019, 9:06 AM
Lea_WMDE moved this task from Tickets in preparation/investigation to prio 2 tickets on the Move-Files-To-Commons board.May 29 2019, 6:43 AM
Raymond subscribed.Jun 12 2019, 4:58 PM

After adding categories manually the warning/hint is still shown.

grafik.png (395×688 px, 16 KB)

WMDE-Fisch mentioned this in T225693: After adding categories manually the warning to add categories is still shown.Jun 13 2019, 6:55 AM
awight closed this task as Resolved.Sep 10 2019, 10:18 PM

The last bit of this should be fixed with T228992: Ask users to add a (non hidden) category, if there are only hidden ones. Closing since the design work is complete.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL