Remove `body` `line-height` from ui.less
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	May 9 2019, 11:55 AM

Description

body receives a specific line-height in 'main.less', therefore the other definitions are overwritten and obsolete.

Expected outcome

Remove body line-height from ui.less

Details

	Subject	Repo	Branch	Lines +/-
	Remove duplicated `line-height`	mediawiki/skins/MinervaNeue	master	+0 -2
	Remove unnecessary `line-height` definitions	mediawiki/skins/MinervaNeue	reset-cleanup	+0 -6

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	None	T285352 [GOAL] ResourceLoader modules performance related improvements in Minerva skins
Resolved	None	T205341 Replace reset.css rules with ResourceLoaderSkinModule `normalize` feature
Resolved	Volker_E	T222877 Remove `body` `line-height` from ui.less

Event Timeline

Volker_E created this task.May 9 2019, 11:55 AM

Change 509045 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@reset-cleanup] Remove unnecessary line-height definitions

https://gerrit.wikimedia.org/r/509045

gerritbot added a project: Patch-For-Review.May 9 2019, 12:12 PM

Change 509045 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@reset-cleanup] Remove unnecessary line-height definitions

https://gerrit.wikimedia.org/r/509045

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.May 9 2019, 5:50 PM

Jdlrobson moved this task from Needs Prioritization to Tracking on the Web-Team-Backlog board.

Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.

matmarex unsubscribed.May 9 2019, 5:55 PM

Ladsgroup removed a project: Patch-For-Review.May 21 2019, 10:07 PM

Change 556307 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Remove duplicated line-height

https://gerrit.wikimedia.org/r/556307

gerritbot added a project: Patch-For-Review.Dec 11 2019, 2:30 AM

Volker_E renamed this task from [subtask] Remove `body` `line-height` from reset.less and ui.less to Remove `body` `line-height` from ui.less.Dec 11 2019, 2:33 AM

Volker_E removed a project: Front-end-Standards-Group.

Volker_E updated the task description. (Show Details)

Change 556307 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove duplicated line-height

https://gerrit.wikimedia.org/r/556307

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.11; 2019-12-17).Dec 11 2019, 5:00 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 11 2019, 5:10 AM

Volker_E closed this task as Resolved.Dec 11 2019, 5:18 AM

Volker_E claimed this task.

Volker_E updated the task description. (Show Details)