Page MenuHomePhabricator

move-subpages counts $wgMaximumMovedPages incorrectly
Closed, ResolvedPublic

Description

Author: mike.lifeguard+bugs

Description:
I tried to use move-subpages to move a bunch of subpages. However, many of these had already been moved in a previous run. Those already-moved pages were counted towards $wgMaximumMovedPages, and thus no pages were actually moved on the second run. Obviously only pages that are actually moved in the current action should be counted towards this limit.

For example:
"Opening theory in chess" has been moved to "Chess Opening Theory"

A redirect has been created.

  • The page Chess Opening Theory/1. Na3 already exists and cannot be automatically overwritten.

...498 more...

  • The page Chess Opening Theory/1. e4/1...c5/2. Nf3/2...e6/3. d4/3...cxd4/4. Nxd4/4...Nf6/5. Nc3 already exists and cannot be automatically overwritten.
  • The maximum of 500 pages has been moved and no more will be moved automatically.

So all of the pages that were counted towards the $wgMaximumMovedPages limit were actually not moved, which is wrong.


Version: 1.16.x
Severity: normal

Details

Reference
bz20289

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:52 PM
bzimport set Reference to bz20289.
bzimport added a subscriber: Unknown Object (MLST).

mike.lifeguard+bugs wrote:

You asked for it :D

ayg wrote:

Fixed in r55289.