Page MenuHomePhabricator

Show progress/activity if a save request is still being processed
Open, Needs TriagePublic2 Story Points

Description

Motivation
As a Wikidata mobile editor
When I click on save
I want to see that something is happening even if the save has not succeeded yet

Mock

Acceptance Criteria

  • Once the request was sent, there is an indicator of progress as shown in the mock
  • The progress indicator in indeterminate
  • The progress indicator behaves as the OOUI one: https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui.ProgressBarWidget
    • instead of blue the moving part will show a cutout of the Wikidata logo
    • the logo will always be 40% of the width of the total bar (proportions will change throughout different width as the heights always remains 20px)
  • If the save failed (i.e. the page mode stays in edit mode) or succeeded, the progress indicator disappears

Asset
svg of the Wikidata logo: https://commons.wikimedia.org/wiki/File:Wikidata-logo.svg

Notes
Maybe this could be done entirely in css. @Lucas_Werkmeister_WMDE created a demo a while ago.

Event Timeline

Lea_WMDE created this task.May 9 2019, 2:21 PM
Lea_WMDE updated the task description. (Show Details)May 29 2019, 12:52 PM
Lea_WMDE updated the task description. (Show Details)May 29 2019, 2:43 PM
Lea_WMDE set the point value for this task to 2.
Lea_WMDE added a subscriber: Hanna_Petruschat_WMDE.
Pablo-WMDE updated the task description. (Show Details)May 29 2019, 3:45 PM
Pablo-WMDE added a subscriber: Lucas_Werkmeister_WMDE.
Hanna_Petruschat_WMDE removed the point value for this task.
Jakob_WMDE set the point value for this task to 2.Wed, Jul 3, 3:46 PM
Jakob_WMDE added a subscriber: Jakob_WMDE.

Adding the story points back, as the latest changes to the description do not affect its complexity as far as I can tell.

Tarrow renamed this task from Show progress/activity if a save request is still being procesed to Show progress/activity if a save request is still being processed.Mon, Jul 15, 8:46 AM
Tarrow claimed this task.Mon, Jul 15, 2:49 PM
Tarrow moved this task from To Do to Doing on the Wikibase-Termbox-Iteration-20 board.

Change 524022 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[wikibase/termbox@master] Introduce IndeterminateProgressBar

https://gerrit.wikimedia.org/r/524022

Change 524188 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[wikibase/termbox@master] Show IndeterminateProgressBar when saving

https://gerrit.wikimedia.org/r/524188

Love it.

IE11:

In integration with mw (FF):

Change 524541 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Bump Termbox Pin

https://gerrit.wikimedia.org/r/524541

Change 524022 merged by jenkins-bot:
[wikibase/termbox@master] Introduce IndeterminateProgressBar

https://gerrit.wikimedia.org/r/524022

Change 524188 merged by jenkins-bot:
[wikibase/termbox@master] Show IndeterminateProgressBar when saving

https://gerrit.wikimedia.org/r/524188

Change 524541 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Bump Termbox Pin

https://gerrit.wikimedia.org/r/524541

@Lea_WMDE removing the icon from the progress bar happened. This can be seen here: https://tools-static.wmflabs.org/wikibase-termbox-storybook/?path=/story/indeterminateprogressbar--default

Hidden question: What do you think about product-reviewing minor changes like this in the continuously deployed storybook instead of beta?