Page MenuHomePhabricator

Show progress/activity if a save request is still being processed
Closed, ResolvedPublic2 Estimated Story Points


As a Wikidata mobile editor
When I click on save
I want to see that something is happening even if the save has not succeeded yet


Bildschirmfoto 2019-05-29 um 16.32.36.png (664×776 px, 81 KB)

Acceptance Criteria

  • Once the request was sent, there is an indicator of progress as shown in the mock
  • The progress indicator in indeterminate
  • The progress indicator behaves as the OOUI one:!/api/OO.ui.ProgressBarWidget
    • instead of blue the moving part will show a cutout of the Wikidata logo The bar will be blue for a start as the logo should not be cropped and might not be the most suitable solution for wikibase instances anyways
    • the logo will always be 40% of the width of the total bar (proportions will change throughout different width as the heights always remains 20px)
  • If the save failed (i.e. the page mode stays in edit mode) or succeeded, the progress indicator disappears

svg of the Wikidata logo:

Maybe this could be done entirely in css. @Lucas_Werkmeister_WMDE created a demo a while ago.

Event Timeline

Jakob_WMDE set the point value for this task to 2.Jul 3 2019, 3:46 PM
Jakob_WMDE subscribed.

Adding the story points back, as the latest changes to the description do not affect its complexity as far as I can tell.

Tarrow renamed this task from Show progress/activity if a save request is still being procesed to Show progress/activity if a save request is still being processed.Jul 15 2019, 8:46 AM
Tarrow edited projects, added Wikibase-Termbox-Iteration-20; removed Wikidata-Termbox.

Change 524022 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[wikibase/termbox@master] Introduce IndeterminateProgressBar

Change 524188 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[wikibase/termbox@master] Show IndeterminateProgressBar when saving

Love it.


VirtualBox_IE11 - Win7_19_07_2019_13_47_56.png (979×1 px, 56 KB)

In integration with mw (FF):

Bildschirmfoto von 2019-07-19 14-13-49.png (1×1 px, 131 KB)

Change 524541 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Bump Termbox Pin

Change 524022 merged by jenkins-bot:
[wikibase/termbox@master] Introduce IndeterminateProgressBar

Change 524188 merged by jenkins-bot:
[wikibase/termbox@master] Show IndeterminateProgressBar when saving

Change 524541 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Bump Termbox Pin

@Lea_WMDE removing the icon from the progress bar happened. This can be seen here:

Hidden question: What do you think about product-reviewing minor changes like this in the continuously deployed storybook instead of beta?

Hey @Jakob_WMDE, thanks for the link! I checked beta and the storybook and it looks great to me! I think the storybook link works fine for me to see that you chose a blue (and if you want to have an intermediary check that is a great way to do it), but for acceptance testing I think I would feel more secure if I could look at the integrated version on beta, as this is as close to the user experience as we can get.

I took the following extra details from figma:

  • Height of the progress bar is always 20px
  • From the two examples it appeared to be as close as possible to horizontally and vertically centered so I did this
  • box-shadow is added
  • border colour is as specfied (#A2A9B1)

I took the following from OOUI:

  • Time of animation repeat is 2s
  • Start of animation is 'bar' totally out of view left
  • End of animation is totally out of view right

On beta, the loading bar is still in Wikidata colors. Could you update the code base @Tarrow ? Thanks!