Currently show/hide button only carries “show” and “hide” as links without a fully concise explanation about what they are showing and hiding aside of the legend being the next element in DOM.
It should provide an indicative aria-expanded attribute.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T191868 OOUI in HTMLForm on Special:Pages – evaluate collapsible main forms | |||
| Resolved | Volker_E | T222904 Collapsible HTMLForm state by jquery.makeCollapsible should be clearer exposed to screen readers |
Event Timeline
Comment Actions
As we probably can't easily add ids to the collapsible-content and a connected [[ http://www.heydonworks.com/article/aria-controls-is-poop | aria-controls attribute ]] (which has been stated to be dysfunctional in several readers at 2016), we should nonetheless add aria-expanded attribute to provide direct feedback on the button about its state apart from showing and hiding text content in DOM afterwards.
In this way, we provide a second, label-independent, standard feedback to screen readers.
Comment Actions
Change 513013 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Improve collapsible HTMLForm styling (and accessibility, slightly)
Comment Actions
Change 538136 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Add toggleARIA option and functionality
Comment Actions
Change 538136 merged by jenkins-bot:
[mediawiki/core@master] jquery.makeCollapsible: Add toggleARIA option and enable for plain toggle
Comment Actions
With above ARIA option and output added, the technically useful and feasible has been achieved. As stated in this [[ https://www.heydonworks.com/article/aria-controls-is-poop | 2016 article, aria-controls support has been somewhat dissatisfyingly weak ]] and doesn't seem to provide added value for the time being.
The solution on adding aria-expanded now provides feedback that the $toggle is controlling an expandable section and if the section is a (direct) sibling of the toggle, screen readers also expose the relation correctly.
Comment Actions
Change 513013 merged by jenkins-bot:
[mediawiki/core@master] Improve collapsible HTMLForm styling (and accessibility, slightly)