Page MenuHomePhabricator

CX2: Restoring logic broken when article starts with empty paragraph
Closed, ResolvedPublic

Description

Haven't noticed this happening before T204308.

  1. Start translating en:Foreign relations of Barbados to Spanish
  2. Translate section starting with "At the political level"
  3. Save, return to dashboard and load the draft again

Result: Section that is effectively 3rd (because first section is empty) is restored against 1st, empty section.

There is a separate ticket for some articles starting with an empty paragraph - T200327.

This problem is the most likely cause behind T222882

Details

Related Gerrit Patches:
mediawiki/extensions/ContentTranslation : masterDon't match whitespace as included content while restoring

Event Timeline

Petar.petkovic moved this task from Needs Triage to CX2 on the ContentTranslation board.

@Pginer-WMF, the number of articles starting with an empty paragraph is not insignificant and publishing error described in T222882 will always happen when section is not properly restored like this (might not be the only case when T222882 occurs). Because of this, I think this ticket should be added to Language-Team (Language-2019-April-June) priority backlog. Maybe it's also a high priority ticket.

Pginer-WMF triaged this task as High priority.May 9 2019, 4:19 PM

@Pginer-WMF, the number of articles starting with an empty paragraph is not insignificant and publishing error described in T222882 will always happen when section is not properly restored like this (might not be the only case when T222882 occurs). Because of this, I think this ticket should be added to Language-Team (Language-2019-April-June) priority backlog. Maybe it's also a high priority ticket.

The assessment makes perfect sense. I moved to the current sprint as high priority, being also related to another ticket in this area such as T220790.

Change 509174 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Don't match whitespace as included content while restoring

https://gerrit.wikimedia.org/r/509174

Change 509174 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Don't match whitespace as included content while restoring

https://gerrit.wikimedia.org/r/509174

Pginer-WMF closed this task as Resolved.May 24 2019, 12:44 PM

Restoring the article of the example shows the translation paragraph in the right position (next to the equivalent in the source) and sentence highlighting works as expected for it: