Page MenuHomePhabricator

Make addWiki.php modular
Open, Needs TriagePublic

Description

This is to make fixing after the script easier (=without the need of eval.php). See T210752#5167695 for more information.

Event Timeline

Urbanecm created this task.May 9 2019, 5:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 9 2019, 5:20 PM
Reedy added a subscriber: Reedy.May 9 2019, 7:17 PM

Who needs to use eval.php?

Just comment out large blocks of the code, and re-run it...

Aaron did some amount of this in https://github.com/wikimedia/mediawiki-extensions-WikimediaMaintenance/commit/8e5382f75f608a0da3709615a6ea933392664468#diff-c2cbc3a14b46d0c8e0ee62091f5b07b8

The author of the comment I linked (@Ladsgroup) said he needed to use eval.php.

Who needs to use eval.php?
Just comment out large blocks of the code, and re-run it...
Aaron did some amount of this in https://github.com/wikimedia/mediawiki-extensions-WikimediaMaintenance/commit/8e5382f75f608a0da3709615a6ea933392664468#diff-c2cbc3a14b46d0c8e0ee62091f5b07b8

Commenting out production code in the maintenance node is not clean, It would be great to move the parts to methods and then have an option for skipping or only running one part.