Page MenuHomePhabricator

Make error messages resulting from failed requests state clearly that it's a MediaWiki's fault not wsexport's
Closed, ResolvedPublic

Description

Right now, an API request that times out on the MW side, is reported with an unhelpful message like this. This would result in fewer complaints from users and improve the subjective satisfaction with the tool.

Wikisource servers returned an error: blah blah

Event Timeline

Samwilson added a subscriber: Samwilson.

Merged and live on the test site.

@MaxSem Can you edit the task description to say what the new message is?
Also, should there be new tasks for the new errors Dom is seeing?

The first two are addressed by https://github.com/wsexport/tool/pull/176, third appears to be a load issue.

The first two are addressed by https://github.com/wsexport/tool/pull/176, third appears to be a load issue.

Okay. Can you also update this task to say what the new error message will be?

The PDF from the github issue - https://tools.wmflabs.org/wsexport-test/book.php?lang=fr&format=pdf-a5&page=Manuel_des_principes_de_musique_(F%C3%A9tis) - returns:

Wikisource servers returned an error: PHP fatal error:
entire web request took longer than 60 seconds and timed out

Which is consistent with the error format from the description.

Items 1 and 2 in T222932#5232730 no longer return an error. The PDFs generate correctly.

For regression purposes I retested some PDFs which have caused us problems in the past. Either they generated fine or they had the same load issue as https://phabricator.wikimedia.org/P8588 (e.g. this file). It might be worth investigating the latter issue as I don't believe I have seen it before.

For regression purposes I retested some PDFs which have caused us problems in the past. Either they generated fine or they had the same load issue as https://phabricator.wikimedia.org/P8588 (e.g. this file). It might be worth investigating the latter issue as I don't believe I have seen it before.

Thanks @dom_walden. @MaxSem can you check if this issue is being caused by work on this ticket? If so, we should fix it with this, else open a new ticket.

Let's open a new ticket.

Here: T225686: Load issue with pdfs . Please feel free to expand on the description.