[betalabs] TypeError: data.homepagequestionstore.questions.forEach is not a function
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	May 10 2019, 2:30 AM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Etonkovidova

kostajh

Description

Found in betalabs when checking T222124. When loading, Special:Homepage displays the following Console error:

TypeError: data.homepagequestionstore.questions.forEach is not a function
The error points to :

data.homepagequestionstore.questions.forEach(function (questionRecord) {
              if (questionRecord.isArchived) {
                archivedCount++;
              } else {
                unarchivedCount++;
              }

The error seems to be displayed on every Homepage (not only for users who had archived/unarchived questions).

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Return empty array if there are no questions	Kosta Harlan	mediawiki/extensions/GrowthExperiments	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: rEGRE0f76320ece26: Return empty array if there are no questions
rEGREd888a7a829eb: Return empty array if there are no questions
Mentioned Here: T222124: Homepage: recent questions stay archived even when revived

Event Timeline

Etonkovidova created this task.May 10 2019, 2:30 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2019, 2:30 AM

kostajh claimed this task.May 10 2019, 5:33 PM

kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 509474 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Return empty array if there are no questions

https://gerrit.wikimedia.org/r/509474

gerritbot added a project: Patch-For-Review.May 10 2019, 5:39 PM

kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 10 2019, 5:40 PM

kostajh mentioned this in rEGREd888a7a829eb: Return empty array if there are no questions.May 10 2019, 5:42 PM

kostajh mentioned this in rEGRE0f76320ece26: Return empty array if there are no questions.May 10 2019, 5:55 PM

Change 509474 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Return empty array if there are no questions

https://gerrit.wikimedia.org/r/509474

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).May 10 2019, 11:00 PM

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 13 2019, 5:49 PM

Etonkovidova closed this task as Resolved.May 14 2019, 5:12 PM

• Petar.petkovic removed a project: Patch-For-Review.May 14 2019, 5:34 PM