We're using a few different conventions for namespaces in the tests directory. Here are a few,
FileImporter\Tests\Services\Wikitext FileImporter\Services\Test FileImporter\Tests\Operations FileImporter\Operations\Test
Let's choose one consistent pattern, perhaps FileImporter\Tests\…, so that classes can be addressed using PSR-4 and to make it clear how to choose namespaces for additional classes in the future.
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/FileImporter | master | +30 -30 | Rename tests namespace to PSR-4 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | thiemowmde | T223523 Newcomer-friendly FileImporter tasks at the Hackathon 2019 | |||
| Resolved | awight | T223021 Clean up FileImporter test class namespaces |
From my experience, the best naming scheme is FileImporter\Tests\…, followed by a copy of the namespace of the file under test. The most relevant advantage of this scheme is that it allows very convenient PSR-4 class loading.
However, the impact of this is super-low, as test classes are typically never loaded in any code. We should do it anyway, for our own sanity and because it's very fast to do.
+1 that works!
test classes are typically never loaded in any code
Hopefully, we do end up encapsulating some of the repeated test code in which case PSR-4 will be helpful!
Change 514451 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/FileImporter@master] Rename tests namespace to PSR-4
Change 514451 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Rename tests namespace to PSR-4