Page MenuHomePhabricator
Create Task
Maniphest T223112

Migrate background image handling to use LESS variables
Closed, ResolvedPublic
Actions

Description

Currently we're just mimicking how the logo is placed by default in skin styles in general (ResourceLoaderSkinModule).

Variables are neater and would resolve issues with only being able to use one RL class per module, as we can just lump a whole bunch of variables in a single one and be done with it.

Details

SubjectRepoBranchLines +/-
Migrate backdrop image style generation to set a variable we use in the LESS instead of adding the styles prebakedmediawiki/skins/Timelessmaster+54 -49
Customize query in gerrit

Related Objects

Event Timeline

Isarra created this task.May 13 2019, 3:05 PM
Isarra mentioned this in T132036: Make background silhouette image customisable.
Isarra moved this task from Backlog to In progress, or perhaps should be on the Timeless board.Jun 19 2019, 8:06 PM
Isarra moved this task from In progress, or perhaps should be to Features on the Timeless board.Aug 13 2019, 9:57 PM
Isarra moved this task from Features to In progress, or perhaps should be on the Timeless board.Aug 16 2019, 5:32 PM
gerritbot added a comment.Aug 17 2019, 3:12 AM

Change 530651 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Migrate background image handling to use ResourceLoaderLessVarFileModule

https://gerrit.wikimedia.org/r/530651

gerritbot added a project: Patch-For-Review.Aug 17 2019, 3:12 AM
Isarra renamed this task from Migrate logo and background image handling to use ResourceLoaderLessVarFileModule to Migrate logo and background image handling to use LESS variables.Aug 17 2019, 3:50 AM
Isarra updated the task description. (Show Details)

Apparently that was completely the wrong class to be using. Okay.

Isarra added a comment.Aug 17 2019, 6:31 PM

And for proper HiDPI support, logo handling shouldn't even be CSS to begin with. We can spoof it with @media queries, but since we have no damn clue what size of logo people are going to upload, that's not actually going to work, either. Only way to properly support that is to use a srcset or an svg.

Isarra mentioned this in T230663: Use normal images via srcset for the logo for proper HiDPI support (unless it's an svg or something).Aug 17 2019, 6:33 PM
Isarra renamed this task from Migrate logo and background image handling to use LESS variables to Migrate background image handling to use LESS variables.Aug 19 2019, 4:38 PM
gerritbot added a comment.Aug 22 2019, 10:21 PM

Change 530651 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Migrate backdrop image style generation to set a variable we use in the LESS instead of adding the styles prebaked

https://gerrit.wikimedia.org/r/530651

Restricted Repository Identity mentioned this in rSKINa968eabc357b: Update git submodules.Aug 22 2019, 10:23 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 22 2019, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 22 2019, 11:11 PM
Isarra closed this task as Resolved.Aug 23 2019, 4:28 PM
Isarra claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL