| • Charlotte | |
| May 13 2019, 4:32 PM |
| F29605493: Screenshot_20190619-094233.png | |
| Jun 19 2019, 4:55 PM |
| F29605491: Screenshot_20190619-094303_Wikipedia Alpha.jpg | |
| Jun 19 2019, 4:55 PM |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Dbrant | T207338 [EPIC] Suggested edits V2 (Add/edit/translate image captions) | |||
| Resolved | • Sharvaniharan | T223130 Bottom sheet popup for adding/translating/editing image captions |
@schoenbaechler @Charlotte
AFAIK there are additional fields specified in T223132, although the design looks very similar. @schoenbaechler, do the specified fields differ?
- There are some fields we can get from existing APIs. Those fields are structured captions, unstructured captions, description, artist, credit, license, and depicts. Would it be possible to ship a first iteration with just these fields and a link to the file page or would you rather hold off on being able to pull information from the file page?
For me it would be perfectly acceptable to do so. I think these fields are enough to support the use case we care about, which is that the user is able to translate/add a useful caption. @schoenbaechler, do you have a vociferous objection to this?
- Is there a specific list of fields you'd like to try to pull from the file page?
@schoenbaechler - Are there additional fields that we need to support the use case (translating a caption) for V1, or is @JoeWalsh's list in question 2 enough?
- Should the image metadata fields shown here be the same as in T223132?
Yes! As mentioned in T223132 though, I’m planning to discuss the file page draft at the Hackathon. No blocker though, we could process that feedback for captions v2.
- There are some fields we can get from existing APIs. Those fields are structured captions, unstructured captions, description, artist, credit, license, and depicts. Would it be possible to ship a first iteration with just these fields and a link to the file page or would you rather hold off on being able to pull information from the file page?
Isn’t the description the unstructured caption? Otherwise sounds good for a first version, as long as we include the link to the file page with all infos at the bottom of the sheet (see visuals on Zeplin)
- Is there a specific list of fields you'd like to try to pull from the file page
Yes, this would be the current draft (to be discussed at the Hackathon):
@Sharvaniharan: the bottom sheet will be used in these following tasks: T224051, T223131, T223129, T223128. So you’re aware that there might be overlaps. LMK if you have any questions.
@schoenbaechler couple questions...
1.what are the options on the overflow menu?
2.The toolbar scrolls with the dialog as it is not a separate activity and cannot behave like a regular screens' toolbar. Is that ok?
1.what are the options on the overflow menu?
There’s only one right now: “Go to file page”. The reason why it’s hidden in the overflow menu is we don’t want to promote it since it’s not optimized (coming in V2: T223132). I’m thinking about a more prominent button at the bottom for V2.
- The toolbar scrolls with the dialog as it is not a separate activity and cannot behave like a regular screens' toolbar. Is that ok?
Could you provide a video of the behavior you’re describing? (or example) Having a hard time getting a feeling for it.
Thanks!
There’s only one right now: “Go to file page”. The reason why it’s hidden in the overflow menu is we don’t want to promote it since it’s not optimized (coming in V2: T223132). I’m thinking about a more prominent button at the bottom for V2.
So we will have this option on the screen and in the menu, both places?
@Sharvaniharan, I totally forgot about the link at the bottom of the sheet, i think it’s totally enough for now (as you probably suspected)! Please don’t add any overflow option at all, will update the screens.
Thanks for the work on this @Sharvaniharan. Moving the task to QA signoff as all the issues related to the bottom sheet are listed in T225635, namely 3), 8), 9), 10), 25), 26), 28).
Testing on 2.7.50282-alpha-2019-06-18. This is working for me on phone devices, but I am seeing some odd behavior on tablet. When tapping expand, the popup is initially expanding in the bottom 1/4 of the screen.
Tablet
