Page MenuHomePhabricator

Echo Selenium tests - Build failure - Cannot find module wdio-mediawiki/Util
Closed, ResolvedPublic

Description

Some recent builds - ##259-263 - https://integration.wikimedia.org/ci/job/selenium-daily-beta-Echo/ - are failing with

09:37:52 > echo@0.0.1 selenium-test /src
09:37:52 > wdio tests/selenium/wdio.conf.js
09:37:52 
09:37:54 ERROR: Cannot find module 'wdio-mediawiki/Util'
09:37:54 chrome
09:37:54     at Function.Module._resolveFilename (module.js:469:15)
09:37:54     at Function.Module._load (module.js:417:25)
09:37:54     at Module.require (module.js:497:17)
09:37:54     at require (internal/module.js:20:19)
09:37:54     at Object.<anonymous> (/src/tests/selenium/specs/echo.js:6:9)
09:37:54     at Module._compile (module.js:570:32)
09:37:54     at Object.Module._extensions..js (module.js:579:10)
09:37:54     at Module.load (module.js:487:32)
09:37:54     at tryModuleLoad (module.js:446:12)
09:37:54     at Function.Module._load (module.js:438:3)

Note: there were no changes in code between successful build #258 and failed build #259

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2019, 5:48 PM

Possibly an odd npm install failure?

Everything seems fine in the npm logs, for the currently-accepted values of 'fine'.

The Echo extension currently specifies in its package.json file that it depends on wdio-mediawiki version 0.1.7.

The Util class was added in version 0.2.0.

The failure started with 917d003397 / https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Echo/+/494535/, which introduced use of wdio-mediawiki/Util without upgrading the package.

The reason this was not caught by Jenkins on that commit, is T199116.

Change 509910 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Echo@master] build: Upgrade wdio-mediawiki from 0.1.7 to 0.3.0

https://gerrit.wikimedia.org/r/509910

Change 509910 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] build: Upgrade wdio-mediawiki from 0.1.7 to 0.3.0

https://gerrit.wikimedia.org/r/509910

zeljkofilipin triaged this task as Normal priority.May 14 2019, 10:02 AM
zeljkofilipin closed this task as Resolved.May 14 2019, 10:06 AM
zeljkofilipin claimed this task.

The job is green again. Thanks @Jdforrester-WMF and @Krinkle!

I'm not sure why this got assigned to me, maybe because I've resolved the task. Assigning to @Jdforrester-WMF since he created the patch that fixed the problem.