Page MenuHomePhabricator
Create Task
Maniphest T223286

Remove deprecated using schema.* syntax from WikiEditor
Closed, ResolvedPublic
Actions

Description

Code search tells me there are uses of something like `using( 'schema.*' ) in:

  • modules/ext.wikiEditor.js#19

I'm going to change this to use mw.track

Details

SubjectRepoBranchLines +/-
Remove mentions of schema.* ResourceLoader modulesmediawiki/extensions/WikiEditormaster+3 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Milimetric created this task.May 14 2019, 3:21 PM
Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.May 15 2019, 12:01 AM
gerritbot added a comment.May 15 2019, 1:20 AM

Change 510285 had a related patch set uploaded (by Milimetric; owner: Milimetric):
[mediawiki/extensions/WikiEditor@master] Remove mentions of schema.* ResourceLoader modules

https://gerrit.wikimedia.org/r/510285

gerritbot added a project: Patch-For-Review.May 15 2019, 1:20 AM
Milimetric moved this task from Next Up to In Code Review on the Analytics-Kanban board.May 15 2019, 1:23 AM
gerritbot added a comment.May 15 2019, 8:42 AM

Change 510285 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Remove mentions of schema.* ResourceLoader modules

https://gerrit.wikimedia.org/r/510285

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 15 2019, 9:00 AM
Milimetric moved this task from In Code Review to Done on the Analytics-Kanban board.May 16 2019, 2:20 PM
mforns triaged this task as High priority.May 16 2019, 5:07 PM
mforns moved this task from Incoming to Operational Excellence on the Analytics board.
Krinkle removed a project: Performance-Team (Radar).May 20 2019, 11:08 PM
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 3:11 PM
Krinkle removed a project: Technical-Debt (Deprecation process).May 22 2019, 7:05 PM
Krinkle closed this task as Resolved.May 29 2019, 3:30 PM
happy5214 moved this task from Backlog to Closed on the WikiEditor board.Aug 4 2019, 11:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL