Patch for GlobalFunctions.php
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
The original function provided a pair of extra quotes to the command after "cmd.exe /c", which will cause it fail to run. For example, when running [[mw:Extension:CodeReview]]::svnImport.php, it generates:
cmd.exe /c ""svn diff -r29:30 --non-interactive --trust-server-cert "/* REPO PATH */"""
And this will cause a "The filename, directory name, or volume label syntax is incorrect." error.
Maybe the patch will fix it. Best regards.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (MingW32)
iD8DBQFKj/QgRsiNGHPeu/URAsMuAJ4lySnYXXcPSuGUgwCROgnmNS48+QCfYs5yszJ9QWMzlJezFIuUlTUj/BA==qUgX
-----END PGP SIGNATURE-----
Version: unspecified
Severity: normal
OS: Windows Vista
Attached: