Editing of collapsible quotations doesn't work on English Wiktionary
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	jberkel
	May 17 2019, 11:27 AM

Description

Steps to Reproduce:

On the English Wiktionary, I wanted to edit the quotation of an entry (let's say Rabenmutter)
I open the page, the quotations are hidden by default. I click on "quotations" to make them visible
I click on "Edit" to edit the page

Actual Results:

The quotations are gone

Expected Results:

The quotations are displayed and I can edit them

What is needed to make them editable in VE? The other collapsible elements (synonyms etc.) are visible in edit mode, I'm not sure what's different there.

Related Objects

Mentioned In: T241599: The [quotations ▲] at the English Wiktionary is not supported
Mentioned Here: T42812: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state)

Event Timeline

jberkel created this task.May 17 2019, 11:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 17 2019, 11:27 AM

The quotes are hidden by the following rule in https://en.wiktionary.org/wiki/MediaWiki:Common.css:

/* Hidden quotes */
.client-js .ns-0 ol>li>ul {
	display: none;
}

I found when and why that was added:

I would recommend the following approach, inspired by the solution we used for mw-collapsible elements (T42812):

The gadget https://en.wiktionary.org/wiki/MediaWiki:Gadget-defaultVisibilityToggles.js is extended to add a CSS class to the <body> node, e.g. wikt-defaultVisibilityToggles-done
The CSS selectors are changed to only apply when that class is not added, i.e. .client-js body:not(.wikt-defaultVisibilityToggles-done) .NavContent, .client-js body:not(.wikt-defaultVisibilityToggles-done).ns-0 ol>li>ul

This should allow the quotations/boxes to be collapsed before the JS loads, but it will not collapse unprocessed onces inside VE.

thanks for the research and recommendation. I'm a bit unclear on what exactly happens when the VE is loaded. If there's is logic inside the gadget which hides quotes or other content, won't that get applied in VE as well?

When VE opens, it replaces the existing content on the page with a fresh copy (without any changes gadgets might have made to it). The gadget doesn't run after VE opens, it only runs after the page is loaded.

Ok, but the Gadget's change to the body tag must still be kept, otherwise the display: none would be active again? So VE just replaces the content inside div#content I suppose?

Yes, that's right.

JTannerWMF moved this task from To Triage to External and Administrivia on the VisualEditor board.May 21 2019, 3:54 PM

For future reference, the related on-wiki discussion: https://en.wiktionary.org/wiki/Wiktionary:Grease_pit/2019/May#Editing_quotations_with_VisualEditor

matmarex merged a task: T241599: The [quotations ▲] at the English Wiktionary is not supported.Dec 30 2019, 7:20 PM

matmarex mentioned this in T241599: The [quotations ▲] at the English Wiktionary is not supported.

matmarex added a subscriber: • Whatamidoing-WMF.

Editing of collapsible quotations doesn't work on English WiktionaryOpen, Needs TriagePublicBUG REPORTActions

Description

Related Objects

Event Timeline

Editing of collapsible quotations doesn't work on English Wiktionary
Open, Needs TriagePublicBUG REPORT
Actions