Undefined index error after unpack() from MimeAnalyzer.php
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request URL: POST /w/api.php
Request ID: urgpAMDkAAGdtcScAAADB

message

[{exception_id}] {exception_url} ErrorException from line 809 of /srv/mediawiki/php-1.34.0-wmf.5/includes/libs/mime/MimeAnalyzer.php: PHP Notice: Undefined index: 0

trace

#0 /srv/mediawiki/php-1.34.0-wmf.5/includes/libs/mime/MimeAnalyzer.php(809): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.34.0-wmf.5/includes/libs/mime/MimeAnalyzer.php(608): MimeAnalyzer->doGuessMimeType(string, boolean)
#2 /srv/mediawiki/php-1.34.0-wmf.5/includes/utils/MWFileProps.php(73): MimeAnalyzer->guessMimeType(string, boolean)
#3 /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadBase.php(506): MWFileProps->getPropsFromPath(string, string)
#4 /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadFromChunks.php(404): UploadBase->verifyPartialFile()
#5 /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadFromChunks.php(67): UploadFromChunks->verifyChunk()
#6 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiUpload.php(315): UploadFromChunks->tryStashFile(User, boolean)
#7 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiUpload.php(212): ApiUpload->performStash(string)
#8 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiUpload.php(132): ApiUpload->getChunkResult(array)
#9 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiUpload.php(104): ApiUpload->getContextResult()
#10 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiMain.php(1593): ApiUpload->execute()
#11 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiMain.php(531): ApiMain->executeAction()
#12 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#13 /srv/mediawiki/php-1.34.0-wmf.5/api.php(87): ApiMain->execute()
#14 /srv/mediawiki/w/api.php(3): include(string)

Impact

Unknown. Could be causing corruption. Might be unrecoverable, uncertain at this point.

Notes

Happened several hundred times over the last 30 days, since at least php-1.34.0-wmf.1, possibly earlier.

Last modification to the code was:

https://gerrit.wikimedia.org/r/502779 / rMW94033330b43f: Third argument to unpack() requires PHP 7.1.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	MimeAnalyzer: fix ZIP parsing failure	mediawiki/core	master	+38 -2

Customize query in gerrit

Related Objects

Mentioned In: Blog Post: Production Excellence #11: May 2019
Blog Post: Production Excellence #10: April 2019
Mentioned Here: rMWf12db3804882: Better detection for old MS Office files
rMW94033330b43f: Third argument to unpack() requires PHP 7.1

Event Timeline

Krinkle created this task.May 18 2019, 3:24 PM

Restricted Application added projects: Commons, Multimedia. · View Herald TranscriptMay 18 2019, 3:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Krinkle moved this task from Untriaged to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.May 18 2019, 3:24 PM

Krinkle mentioned this in Blog Post: Production Excellence #10: April 2019.May 31 2019, 7:21 PM

It looks like the indices of the array returned by unpack here actually begin at 1: https://www.php.net/manual/en/function.unpack.php#refsect1-function.unpack-notes

https://gerrit.wikimedia.org/r/502779 / rMW94033330b43f: Third argument to unpack() requires PHP 7.1

Tagging author (@Simetrical, Platform Engineering) and reviewer (@aaron).

We're going to move this into our team board to be scheduled into a next sprint for one of CPT's sub teams.

Krinkle mentioned this in Blog Post: Production Excellence #11: May 2019.Jul 1 2019, 6:48 PM

• WDoranWMF moved this task from Backlog to mop on the Platform Team Workboards (Team 3) board.Jul 17 2019, 4:45 PM

• WDoranWMF removed a project: Platform Team Workboards (Team 3).

• WDoranWMF added a project: Platform Team Workboards (Clinic Duty Team).

• WDoranWMF assigned this task to tstarling.Jul 17 2019, 8:16 PM

• WDoranWMF moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.

In T223728#5263456, @Krinkle wrote:

Tagging author (@Simetrical, Platform Engineering) and reviewer (@aaron).

Actually, I was the author of this bug, in rMWf12db3804882272794b4dafc72db1c5d787375bf. The change you linked to just preserved it.

Change 525472 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/core@master] MimeAnalyzer: fix ZIP parsing failure

https://gerrit.wikimedia.org/r/525472

gerritbot added a project: Patch-For-Review.Jul 25 2019, 3:45 AM

tstarling moved this task from Later to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Jul 25 2019, 6:33 AM

Change 525472 merged by jenkins-bot:
[mediawiki/core@master] MimeAnalyzer: fix ZIP parsing failure

https://gerrit.wikimedia.org/r/525472

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 25 2019, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2019, 2:11 PM

Anomie moved this task from Waiting for Review to EM Sign Off on the Platform Team Workboards (Clinic Duty Team) board.Jul 25 2019, 2:27 PM

Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Resolved on the Wikimedia-production-error board.Jul 25 2019, 3:48 PM

• WDoranWMF moved this task from EM Sign Off to Done on the Platform Team Workboards (Clinic Duty Team) board.Jul 26 2019, 5:30 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM

Looks like this is done.

Undefined index error after unpack() from MimeAnalyzer.phpClosed, ResolvedPublicPRODUCTION ERRORActions