Page MenuHomePhabricator
Create Task
Maniphest T223729

MVV does not copy share URL to clipboard: "TypeError: pane.pageInput.$input.triger is not a function"
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. https://en.wikipedia.org/wiki/Alan_Turing#/media/File:Alan_Turing_Aged_16.jpg
  2. Click "share or embed this file"
  3. Click "select and copy" to clipboard

Actual Results:

  • Not in clipboard.
  • TypeError: pane.pageInput.$input.triger is not a function

Expected Results:

Details

SubjectRepoBranchLines +/-
Fix copy share URL to clipboardmediawiki/extensions/MultimediaViewermaster+1 -1
Customize query in gerrit

Event Timeline

simon04 created this task.May 18 2019, 3:27 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptMay 18 2019, 3:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
simon04 added a project: Wikimedia-Hackathon-2019.May 18 2019, 3:31 PM
Aklapper renamed this task from MVV does not copy share URL to clipboard to MVV does not copy share URL to clipboard: "TypeError: pane.pageInput.$input.triger is not a function".May 18 2019, 3:34 PM
Aklapper added a project: good first task.

In ./resources/mmv.ui.reuse.shareembed/mmv.ui.reuse.share.js in MultimediaViewer, triger should be trigger

simon04 added a comment.May 18 2019, 3:36 PM

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MultimediaViewer/+/511049

gerritbot added a comment.May 18 2019, 5:16 PM

Change 511049 had a related patch set uploaded (by Jdlrobson; owner: Simon04):
[mediawiki/extensions/MultimediaViewer@master] Fix copy share URL to clipboard

https://gerrit.wikimedia.org/r/511049

gerritbot added a project: Patch-For-Review.May 18 2019, 5:16 PM
gerritbot added a comment.May 18 2019, 5:29 PM

Change 511049 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Fix copy share URL to clipboard

https://gerrit.wikimedia.org/r/511049

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 18 2019, 6:00 PM
Aklapper added a comment.May 19 2019, 1:47 AM

@simon04: Feel free to set the status of this report to "Resolved" via the Add Action... → Change Status dropdown if no further work is needed. Thanks!

simon04 closed this task as Resolved.May 19 2019, 9:57 AM
Jdforrester-WMF removed a project: Patch-For-Review.May 19 2019, 10:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL