Page MenuHomePhabricator

Hide system-noemail category from notification preferences
Open, Needs TriagePublic


The system-noemail category (labeled "System") appears in the checkbox matrix in the notification preferences:

This is because AttributeManager::isCategoryDisplayedInPreferences() only looks at whether 'no-dismiss' => ['all'] is set, but system-email (appropriately) has 'no-dismiss' => ['web'], since email is disabled. If we do set no-dismiss' => ['all'], that would lead to email being both un-enableable and un-disableable for this category (ti shows that way on Special:DisplayNotificationsConfiguration, not sure if it has an effect in practice).

Either isCategoryDisplayedInPreferences() should be smarter and return false in this case (where all allowed types are non-dismissable), or no-dismiss should be interpreted differently.

Related Objects

Event Timeline

Catrope created this task.May 18 2019, 3:35 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 18 2019, 3:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript