In T220419#5119845, @Ladsgroup wrote:The tables in the database has changed (according the git blame) and now have more columns and indexes while since they are wired into update.php through patching of existing tables, the beta cluster has completely different schema than the one in the code
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Add missing schema change update patches | Reedy | mediawiki/extensions/Jade | master | +97 -3 |
Related Objects
Related Objects
- Mentioned In
- rEJAD98afe9127108: Add missing schema change update patches
rEJAD726005bac821: Add missing schema change update patches
rEJADdfb8845df9af: Add missing schema change update patches
rEJADd99d12206d75: Add missing schema change update patches
rEJADe70e6179a8be: Add missing schema change update patches
rEJADa63ba215c0f5: Add missing schema change update patches
rEJADbcc208673bb6: Add missing schema change update patches
rEJAD280902e4e4be: Add missing schema change update patches
rEJAD4aca6917e6b2: Add missing schema change update patches - Mentioned Here
- T220419: Write analysis of Jade extension's implementation
Event Timeline
Comment Actions
MariaDB [enwiki]> explain jade_diff_judgment; +----------------+------------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +----------------+------------------+------+-----+---------+----------------+ | jaded_id | int(10) unsigned | NO | PRI | NULL | auto_increment | | jaded_revision | int(10) unsigned | NO | MUL | NULL | | | jaded_judgment | int(10) unsigned | NO | | NULL | | +----------------+------------------+------+-----+---------+----------------+ 3 rows in set (0.00 sec) MariaDB [enwiki]> show indexes from jade_diff_judgment; +--------------------+------------+-------------------------+--------------+----------------+-----------+-------------+----------+--------+------+------------+---------+---------------+ | Table | Non_unique | Key_name | Seq_in_index | Column_name | Collation | Cardinality | Sub_part | Packed | Null | Index_type | Comment | Index_comment | +--------------------+------------+-------------------------+--------------+----------------+-----------+-------------+----------+--------+------+------------+---------+---------------+ | jade_diff_judgment | 0 | PRIMARY | 1 | jaded_id | A | 1 | NULL | NULL | | BTREE | | | | jade_diff_judgment | 0 | jaded_revision_judgment | 1 | jaded_revision | A | 1 | NULL | NULL | | BTREE | | | | jade_diff_judgment | 0 | jaded_revision_judgment | 2 | jaded_judgment | A | 1 | NULL | NULL | | BTREE | | | +--------------------+------------+-------------------------+--------------+----------------+-----------+-------------+----------+--------+------+------------+---------+---------------+ 3 rows in set (0.00 sec) MariaDB [enwiki]> explain jade_revision_judgment; +----------------+------------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +----------------+------------------+------+-----+---------+----------------+ | jader_id | int(10) unsigned | NO | PRI | NULL | auto_increment | | jader_revision | int(10) unsigned | NO | MUL | NULL | | | jader_judgment | int(10) unsigned | NO | | NULL | | +----------------+------------------+------+-----+---------+----------------+ 3 rows in set (0.00 sec) MariaDB [enwiki]> show indexes from jade_revision_judgment; +------------------------+------------+-------------------------+--------------+----------------+-----------+-------------+----------+--------+------+------------+---------+---------------+ | Table | Non_unique | Key_name | Seq_in_index | Column_name | Collation | Cardinality | Sub_part | Packed | Null | Index_type | Comment | Index_comment | +------------------------+------------+-------------------------+--------------+----------------+-----------+-------------+----------+--------+------+------------+---------+---------------+ | jade_revision_judgment | 0 | PRIMARY | 1 | jader_id | A | 0 | NULL | NULL | | BTREE | | | | jade_revision_judgment | 0 | jader_revision_judgment | 1 | jader_revision | A | 0 | NULL | NULL | | BTREE | | | | jade_revision_judgment | 0 | jader_revision_judgment | 2 | jader_judgment | A | 0 | NULL | NULL | | BTREE | | | +------------------------+------------+-------------------------+--------------+----------------+-----------+-------------+----------+--------+------+------------+---------+---------------+ 3 rows in set (0.00 sec)
Comment Actions
Basically, the problem is no one added incremental patch files. Just added more columns and indexes
Comment Actions
Change 511080 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Jade@master] Add missing schema change update patches
Comment Actions
Change 511080 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Add missing schema change update patches
Comment Actions
Thank you for taking this on @Reedy. We'll be working with these tables again soon but they fell off of our radar for a little while. It looks like this is now resolved.