Page MenuHomePhabricator
Create Task
Maniphest T223767

Geodata not being returned for some files
Closed, ResolvedPublic
Actions

Description

This file has a {{location}} template, but it's coordinates are not being returned by the API. For example, it and another image both have coordinates, but only the other has them returned by the API call.

A similar problem seems to exist on Beta Commons as well.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Don't lose CoordinatesOutput when multiple slots are availablemediawiki/extensions/GeoDatamaster+34 -2
Stop accessing ParserOutput::geoData field directlymediawiki/extensions/Wikibasemaster+23 -20
Isolate ParserOutput::geoData magic fieldmediawiki/extensions/GeoDatamaster+50 -21
Customize query in gerrit

Event Timeline

Samwilson created this task.May 19 2019, 7:08 AM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptMay 19 2019, 7:08 AM
Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald Transcript
dcausse claimed this task.May 22 2019, 10:05 AM
dcausse triaged this task as Medium priority.
dcausse moved this task from needs triage to Current work on the Discovery-Search board.
dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.
gerritbot added a comment.May 22 2019, 1:43 PM

Change 511883 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/GeoData@master] Don't lose CoordinatesOutput when multiple slots are available

https://gerrit.wikimedia.org/r/511883

gerritbot added a project: Patch-For-Review.May 22 2019, 1:43 PM
gerritbot added a comment.May 23 2019, 1:21 PM

Change 512167 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/Wikibase@master] Stop accessing ParserOutput::geoData field directly

https://gerrit.wikimedia.org/r/512167

gerritbot added a comment.May 23 2019, 1:21 PM

Change 512166 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/GeoData@master] Isolate ParserOutput::geoData magic field

https://gerrit.wikimedia.org/r/512166

dcausse moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.May 23 2019, 5:48 PM
gerritbot added a comment.May 28 2019, 10:13 PM

Change 512166 merged by jenkins-bot:
[mediawiki/extensions/GeoData@master] Isolate ParserOutput::geoData magic field

https://gerrit.wikimedia.org/r/512166

gerritbot added a comment.May 28 2019, 10:27 PM

Change 512167 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Stop accessing ParserOutput::geoData field directly

https://gerrit.wikimedia.org/r/512167

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).May 28 2019, 11:00 PM
EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Jun 3 2019, 4:44 PM
gerritbot added a comment.Jun 3 2019, 5:26 PM

Change 511883 merged by jenkins-bot:
[mediawiki/extensions/GeoData@master] Don't lose CoordinatesOutput when multiple slots are available

https://gerrit.wikimedia.org/r/511883

Maintenance_bot removed a project: Patch-For-Review.Jun 3 2019, 6:10 PM
• debt closed this task as Resolved.Jun 21 2019, 2:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits