Page MenuHomePhabricator

On non-SET wikis (two edit tabs), links to new pages (red links) should open the user's preferred editor (last used)
Open, Needs TriagePublic

Description

On non-SET wikis (two edit tabs), links to new pages (red links) should open the user's preferred editor (last used) – visual or wikitext. Currently they always open the wikitext editor.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSun, May 19, 10:20 AM

Change 511016 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[operations/mediawiki-config@master] Simplify VisualEditor config variables (1/2)

https://gerrit.wikimedia.org/r/511016

Change 511029 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[operations/mediawiki-config@master] Simplify VisualEditor config variables (2/2)

https://gerrit.wikimedia.org/r/511029

Theklan added a subscriber: Theklan.

Change 511315 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Special-case redlink URLs to load preferred editor

https://gerrit.wikimedia.org/r/511315

Change 511016 merged by jenkins-bot:
[operations/mediawiki-config@master] Simplify VisualEditor config variables (1/2)

https://gerrit.wikimedia.org/r/511016

Mentioned in SAL (#wikimedia-operations) [2019-05-23T22:13:06Z] <jforrester@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T223793 Add wmgVisualEditorIsSecondaryEditor to InitialiseSettings (duration: 00m 49s)

Change 511029 merged by jenkins-bot:
[operations/mediawiki-config@master] Simplify VisualEditor config variables (2/2)

https://gerrit.wikimedia.org/r/511029

Mentioned in SAL (#wikimedia-operations) [2019-05-23T22:17:51Z] <jforrester@deploy1001> Synchronized wmf-config/CommonSettings.php: T223793 Read wmgVisualEditorIsSecondaryEditor in CommonSettings (duration: 00m 48s)

Config simplification landed in production.

Mentioned in SAL (#wikimedia-operations) [2019-05-23T22:19:38Z] <jforrester@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T223793 Drop wmgVisualEditorSingleEditTabSecondaryEditor and wmgVisualEditorSecondaryTabs from InitialiseSettings (duration: 00m 48s)

We should announce this, the change has been requested several times by folks from various wikis. (Also, in case it has unintended consequences – which I hope it doesn't, but the initialization code is complicated due to how many options there are – an early notice would make problems easier to resolve.)

Proposed Tech News text:

On wikis that have separate tabs for visual and wikitext editor, clicking a link to create a new page (red link) will now correctly open your previously used editor, rather than always the wikitext editor.

I guess we're too late for Tech/News/2019/22 (to be sent 27 May), so this would go in Tech/News/2019/23 (3 June). We should make sure the code also goes out in the week of 3 June, so we should merge https://gerrit.wikimedia.org/r/511315 after next branch cut (no sooner than 29 May).

@Whatamidoing-WMF noticed that the config simplification had a minor unintended consequence: on single-edit-tab wikis, where visual editor is secondary (for new users, clicking the [Edit] tab opens wikitext), if you picked "Show me both editor tabs" in preferences, the order of the tabs changed from [Edit] [Edit source] to [Edit source] [Edit].


I think this behavior would have made sense if it worked this way from the start, but now it’s a surprising change, and I'm going to undo it. This problem affects two wikis, enwiki and frwiktionary. So far no users seem to have reported the problem (checking Wikipedia:Village pump (technical) and Wiktionnaire:Questions techniques), so hopefully it wasn't a big inconvenience.

Change 512732 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[operations/mediawiki-config@master] Fix order of "Edit" tabs when multi-tab mode used on single-tab wiki

https://gerrit.wikimedia.org/r/512732

Turns out today is a WMF holiday, so the soonest opportunity to deploy the fix is tomorrow evening: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20190528T2300. I think it can wait for another day, given the lack of complaints.

Johan added a subscriber: Johan.Tue, May 28, 1:42 PM

@matmarex Added to https://meta.wikimedia.org/wiki/Tech/News/2019/23 with some restructuring to make the sentences simpler and shorter. Please take a look and make sure it still makes sense, and feel free to edit as necessary.

Change 512732 merged by jenkins-bot:
[operations/mediawiki-config@master] Fix order of "Edit" tabs when multi-tab mode used on single-tab wiki

https://gerrit.wikimedia.org/r/512732

Mentioned in SAL (#wikimedia-operations) [2019-05-28T22:49:49Z] <jforrester@deploy1001> Synchronized wmf-config/CommonSettings.php: SWAT Fix order of edit tabs for multi-tabs on SET wikis T223793 (duration: 00m 57s)

We can merge the code change now, too.

Change 511315 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Special-case redlink URLs to load preferred editor

https://gerrit.wikimedia.org/r/511315

Cirdan added a subscriber: Cirdan.Mon, Jun 3, 4:14 PM
Trizek awarded a token.Tue, Jun 4, 8:05 AM
ppelberg closed this task as Resolved.Fri, Jun 7, 10:07 PM
ppelberg reopened this task as Open.Sat, Jun 8, 12:36 PM
jeblad added a subscriber: jeblad.EditedSun, Jun 9, 12:30 PM

For those that use all three editors, both VisualEditor and WikitextEditor2017 is unusable for template editing, this is a awkward change as it has now become pretty much random which editor is used. The reason it is pretty much random which editor opens is because it is pretty much random which editor the user last used. It seems like some devs thinks the choice is static, but it is not, users change back and forth all the time.

It isn't often I complain about changes, but in this case I really would like this change to be removed, or fixed so users somehow can expect how the system works. As it is now the user must know what he used last time he edited, which is confusing at best. (And yes, we already have complaints at nowiki.)

So please make a better solution, ASAP!

It seems like some devs thinks the choice is static, but it is not, users change back and forth all the time.

We switch back and forth just as much as any other users, that's why we go to great lengths to preserve changes when switching.

For users that use both editors we can't know which editor they want to use when they click a red link, so our best guess is the editor they last used. It appears that you always want to use the wikitext editor when opening red links, but there will also be users who always want to use the visual editor when opening red links. In this case the best solution is to make a best guess and provide an easy tool to change mode if that guess is incorrect.

This seems like a minor inconvenience for experienced users who often switch between editors (and therefore will know how to switch back to the editor they want), compared the situation before where newer users who had only ever used the visual editor were being shown the wikitext editor, and not even knowing how to get back to VE.

That said I appreciate you may have a use case where it would be convenient to explicitly specify a preferred editor for red links, in which case you could file a follow-up task to create a preference for that.

matmarex moved this task from Inbox to High Priority on the Editing QA board.Wed, Jun 12, 4:12 PM

Without going into specifics; some users will nearly always open a red-linked article in plain old wikitext editor because the initial editing consists mostly of non-content-text, it is mostly markup. Not sure what you would call “brødtekst” in English. For those users it is a major inconvenience to use the visual UI and try to navigate a pointer-based interface.

stjn added a subscriber: stjn.Sun, Jun 16, 8:33 PM

This change has one glaring problem. Most projects have edit notices for people trying to create new pages. This text displays fine in standard wikitext editor, but in any visual editor (we should have a better name for them) it gets shoved away into a small box which usually ends up not fitting the screen. Moreover, an average editor will probably close these notices since they are shown to them once in a tertiary position that gets in the way of editing.

I’ve already said that VisualEditor should change its treatment of edit notices in T212848, but it is an even more important concern for new page creation flow. As I’ve tested on ru.wikipedia.beta.wmflabs.org, VisualEditor gets open by default for most editors, so with this change we will be essentially retiring the standard edit notice without asking anyone.