Page MenuHomePhabricator

Error about manually adding translation tags does not fit the save dialog
Open, Needs TriagePublic

Description

If I try to save a change that manually adds a translation tag (done in the "edit source" mode), Visual Editor shows an error within the save dialog saying that I shouldn't do that.

However, the error message does not fit within the save dialog's size, which can be confusing if the browser does not display a scrollbar. Here's what it looks like:

...and after scrolling down:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 19 2019, 10:52 AM

Hey @Ryasmeen can you check the instances in which this occurs so that @ppelberg and @Esanders can determine when we should work on this? Thanks !

JTannerWMF added a project: Editing QA.

I can't replicate this issue on Beta cluster.

@Ryasmeen please let me know if you need any details of my setup to be able to reproduce this issue. I'm happy to assist however I can.

Ryasmeen added a comment.EditedMay 23 2019, 11:34 PM

@Ryasmeen please let me know if you need any details of my setup to be able to reproduce this issue. I'm happy to assist however I can.

Could you mention on which page you found it with exact steps to reproduce it.

  1. Go to https://www.wikidata.org/wiki/Wikidata:Tools/Query_data#SPARQL_query_builders
  2. Click "edit source" in the "SPARQL query builders" section
  3. Add a <translate> tag, e.g. change |name = Vizquery to |name = <translate><!--T:999-->Vizquery</translate>
  4. Click "publish changes"

The error appears as shown in the screenshot above. The buttons are not visible until I scroll down.

I'm using Firefox 67 on macOS Mojave.

matmarex added a subscriber: matmarex.

I can reproduce it on that page, although it looks like the error message has been made shorter, so it fits now:

There are probably other cases where the message wouldn't fit, but I am not really convinced that we should change our behavior. The interface should probably encourage reading the entire error message before clicking "Try again". The interface is only possibly unclear on macOS, because other sensible operating systems display scrollbars here, and AFAIK we have no way to force it to display scrollbars.