Page MenuHomePhabricator
Create Task
Maniphest T223883

Deploy AMC overflow menu to wikis with AMC enabled
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
ovasileva
May 20 2019, 9:33 AM
Tags
Referenced Files
F29283200: Screen Shot 2019-05-30 at 7.28.11 PM.png
May 31 2019, 3:12 AM
F29283207: Screen Shot 2019-05-30 at 7.36.01 PM.png
May 31 2019, 3:12 AM
F29283268: Screen Shot 2019-05-30 at 7.58.41 PM.png
May 31 2019, 3:12 AM
F29283297: Screen Shot 2019-05-30 at 8.04.50 PM.png
May 31 2019, 3:12 AM
F29283281: Screen Shot 2019-05-30 at 8.02.08 PM.png
May 31 2019, 3:12 AM
F29283257: Screen Shot 2019-05-30 at 7.53.59 PM.png
May 31 2019, 3:12 AM
F29283232: Screen Shot 2019-05-30 at 7.43.09 PM.png
May 31 2019, 3:12 AM
F29283235: Screen Shot 2019-05-30 at 7.44.16 PM.png
May 31 2019, 3:12 AM
View All 12 Files
Subscribers
Aklapper
Edtadros
Masumrezarock100
• nray
ovasileva
pmiazga

Description

Background

We built the overflow menu in T216418: AMC Navigation - overflow menu. Now, we would like to deploy it to all wikis that currently have AMC enabled

Acceptance criteria

  • Deploy AMC overflow menu to wikis with AMC enabled - eswiki, arwiki, idwiki

QA criteria

  1. For eswiki, arwiki, idwiki with AMC turned on:
  2. ensure overflow menu appears on the following pages:
  3. article pages
  4. user pages
  5. article pages that do not exist
  6. user pages that do not exist
  7. ensure links work on overflow menu
  8. note anything that looks out of place
  9. test opening and closing the menu on a couple of devices

QA Results

ACStatusDetails
1✅T223883#5225416
2✅T223883#5225416
3✅T223883#5225416
4✅T223883#5225416
5✅T223883#5225416
6✅T223883#5225416
7✅T223883#5225416

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Enable AdvancedMobileContributions Overflow menuoperations/mediawiki-configmaster+8 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ovasileva created this task.May 20 2019, 9:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2019, 9:33 AM
ovasileva triaged this task as High priority.May 20 2019, 9:33 AM
ovasileva moved this task from Incoming to Upcoming on the Web-Team-Backlog-Archived board.
ovasileva added a subscriber: pmiazga.EditedMay 20 2019, 9:36 AM

Question (most likely for a separate task). @pmiazga - are we currently able to add the overflow menu links to Schema:MobileWebMainMenuClickTracking or will this require changes to the schema?
@ovasileva to set up a task for this

ovasileva added a subtask: T216418: AMC Navigation - overflow menu.May 20 2019, 9:36 AM
ovasileva closed subtask T216418: AMC Navigation - overflow menu as Resolved.
ovasileva mentioned this in T216418: AMC Navigation - overflow menu.
ovasileva set the point value for this task to 1.May 21 2019, 4:37 PM
ovasileva edited projects, added Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4); removed Web-Team-Backlog-Archived.
pmiazga added a comment.May 21 2019, 4:37 PM

Yes, we can reuse the schema, but most probably would be nice to rename the schema. Also - question - currently we track the menu element destination. If there are two menu elements (in different menus) that point to the same page we won't be able to track which menu was used.

• nray subscribed.May 21 2019, 4:37 PM

https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/509130/ might help with this

• nray added a comment.May 21 2019, 6:15 PM
In T223883#5201519, @nray wrote:

https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/509130/ might help with this

Actually, this might not be the best approach. It might be better to just change the MinervaOverflowInPageActions default to be true for amc mode inside skin.json. Currently, it defaults to false for amc

ovasileva added a comment.May 27 2019, 3:31 PM
In T223883#5197207, @ovasileva wrote:

Question (most likely for a separate task). @pmiazga - are we currently able to add the overflow menu links to Schema:MobileWebMainMenuClickTracking or will this require changes to the schema?
@ovasileva to set up a task for this

captured in T220016: Create, and deploy working MobileWebUIActionsTracking schema

pmiazga moved this task from To Do to Doing on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4) board.May 29 2019, 10:28 AM
pmiazga claimed this task.May 29 2019, 10:32 AM
gerritbot added a comment.May 29 2019, 10:37 AM

Change 509130 had a related patch set uploaded (by Pmiazga; owner: Nray):
[operations/mediawiki-config@master] Enable AdvancedMobileContributions Overflow menu

https://gerrit.wikimedia.org/r/509130

gerritbot added a project: Patch-For-Review.May 29 2019, 10:37 AM
gerritbot added a comment.May 29 2019, 11:21 AM

Change 509130 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable AdvancedMobileContributions Overflow menu

https://gerrit.wikimedia.org/r/509130

Stashbot added a comment.May 29 2019, 11:30 AM

Mentioned in SAL (#wikimedia-operations) [2019-05-29T11:30:33Z] <pmiazga@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:509130 Enable Advanced Mobile Contributions Overflow menu (T223883)]] (duration: 00m 57s)

pmiazga removed pmiazga as the assignee of this task.May 29 2019, 11:32 AM
pmiazga assigned this task to ovasileva.
pmiazga moved this task from Doing to Ready for Signoff on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
ovasileva moved this task from Ready for Signoff to Needs QA on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4) board.May 29 2019, 5:03 PM
Maintenance_bot removed a project: Patch-For-Review.May 29 2019, 5:10 PM
ovasileva reassigned this task from ovasileva to Edtadros.May 29 2019, 5:18 PM
ovasileva updated the task description. (Show Details)
ovasileva updated the task description. (Show Details)May 29 2019, 5:24 PM
Edtadros reassigned this task from Edtadros to ovasileva.May 31 2019, 3:12 AM
Edtadros moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Edtadros subscribed.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: iPhone XR (browserstack), Galaxy S9 (browserstack)

Test Artifact(s):

QA criteria

For eswiki, arwiki, idwiki with AMC turned on ensure overflow menu appears on the following pages:

✅ AC1: article pages

eswikiarwikiidwiki
Screen Shot 2019-05-30 at 7.26.22 PM.png (861×447 px, 179 KB)
Screen Shot 2019-05-30 at 7.44.16 PM.png (859×437 px, 198 KB)
Screen Shot 2019-05-30 at 7.58.41 PM.png (852×428 px, 204 KB)

✅ AC2: user pages

eswikiarwikiidwiki
Screen Shot 2019-05-30 at 7.28.11 PM.png (857×452 px, 202 KB)
Screen Shot 2019-05-30 at 7.45.22 PM.png (860×437 px, 258 KB)
Screen Shot 2019-05-30 at 7.59.55 PM.png (855×437 px, 193 KB)

✅ AC3: article pages that do not exist

eswikiarwikiidwiki
Screen Shot 2019-05-30 at 7.36.01 PM.png (859×440 px, 192 KB)
Screen Shot 2019-05-30 at 7.53.59 PM.png (858×431 px, 142 KB)
Screen Shot 2019-05-30 at 8.02.08 PM.png (859×436 px, 208 KB)

✅ AC4: user pages that do not exist

eswikiarwikiidwiki
Screen Shot 2019-05-30 at 7.37.54 PM.png (856×435 px, 212 KB)
Screen Shot 2019-05-30 at 7.43.09 PM.png (860×436 px, 146 KB)
Screen Shot 2019-05-30 at 8.04.50 PM.png (854×434 px, 196 KB)

✅ AC5: ensure links work on overflow menu

eswikiarwikiidwiki
All links above work.All links above work.All links above work.

✅ AC6: note anything that looks out of place

eswikiarwikiidwiki
Nothing out of place.Nothing out of place.Nothing out of place.

✅ AC7: test opening and closing the menu on a couple of devices

eswikiarwikiidwiki
iPhone XRiPhone XRiPhone XR
Galaxy S9Galaxy S9Galaxy S9
Edtadros added a project: Product-QA (RW-Test-Cases).May 31 2019, 3:13 AM
Edtadros updated the task description. (Show Details)
ovasileva closed this task as Resolved.Jun 3 2019, 10:28 AM

Looks great, thanks @Edtadros

ovasileva moved this task from Backlog to Advanced Mobile Contributions on the Product-QA (RW-Test-Cases) board.Mar 2 2020, 6:39 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptMar 2 2020, 6:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits