Page MenuHomePhabricator

Deploy AMC overflow menu to wikis with AMC enabled
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

We built the overflow menu in T216418: AMC Navigation - overflow menu. Now, we would like to deploy it to all wikis that currently have AMC enabled

Acceptance criteria

  • Deploy AMC overflow menu to wikis with AMC enabled - eswiki, arwiki, idwiki

QA criteria

  1. For eswiki, arwiki, idwiki with AMC turned on:
  2. ensure overflow menu appears on the following pages:
  3. article pages
  4. user pages
  5. article pages that do not exist
  6. user pages that do not exist
  7. ensure links work on overflow menu
  8. note anything that looks out of place
  9. test opening and closing the menu on a couple of devices

QA Results

Event Timeline

ovasileva moved this task from Incoming to Upcoming on the Readers-Web-Backlog board.

Question (most likely for a separate task). @pmiazga - are we currently able to add the overflow menu links to Schema:MobileWebMainMenuClickTracking or will this require changes to the schema?
@ovasileva to set up a task for this

Yes, we can reuse the schema, but most probably would be nice to rename the schema. Also - question - currently we track the menu element destination. If there are two menu elements (in different menus) that point to the same page we won't be able to track which menu was used.

Actually, this might not be the best approach. It might be better to just change the MinervaOverflowInPageActions default to be true for amc mode inside skin.json. Currently, it defaults to false for amc

Question (most likely for a separate task). @pmiazga - are we currently able to add the overflow menu links to Schema:MobileWebMainMenuClickTracking or will this require changes to the schema?
@ovasileva to set up a task for this

captured in T220016: Create, and deploy working MobileWebUIActionsTracking schema

Change 509130 had a related patch set uploaded (by Pmiazga; owner: Nray):
[operations/mediawiki-config@master] Enable AdvancedMobileContributions Overflow menu

https://gerrit.wikimedia.org/r/509130

Change 509130 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable AdvancedMobileContributions Overflow menu

https://gerrit.wikimedia.org/r/509130

Mentioned in SAL (#wikimedia-operations) [2019-05-29T11:30:33Z] <pmiazga@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:509130 Enable Advanced Mobile Contributions Overflow menu (T223883)]] (duration: 00m 57s)

Edtadros added a subscriber: Edtadros.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: iPhone XR (browserstack), Galaxy S9 (browserstack)

Test Artifact(s):

QA criteria

For eswiki, arwiki, idwiki with AMC turned on ensure overflow menu appears on the following pages:

✅ AC1: article pages

eswikiarwikiidwiki
Screen Shot 2019-05-30 at 7.26.22 PM.png (861×447 px, 179 KB)
Screen Shot 2019-05-30 at 7.44.16 PM.png (859×437 px, 198 KB)
Screen Shot 2019-05-30 at 7.58.41 PM.png (852×428 px, 204 KB)

✅ AC2: user pages

eswikiarwikiidwiki
Screen Shot 2019-05-30 at 7.28.11 PM.png (857×452 px, 202 KB)
Screen Shot 2019-05-30 at 7.45.22 PM.png (860×437 px, 258 KB)
Screen Shot 2019-05-30 at 7.59.55 PM.png (855×437 px, 193 KB)

✅ AC3: article pages that do not exist

eswikiarwikiidwiki
Screen Shot 2019-05-30 at 7.36.01 PM.png (859×440 px, 192 KB)
Screen Shot 2019-05-30 at 7.53.59 PM.png (858×431 px, 142 KB)
Screen Shot 2019-05-30 at 8.02.08 PM.png (859×436 px, 208 KB)

✅ AC4: user pages that do not exist

eswikiarwikiidwiki
Screen Shot 2019-05-30 at 7.37.54 PM.png (856×435 px, 212 KB)
Screen Shot 2019-05-30 at 7.43.09 PM.png (860×436 px, 146 KB)
Screen Shot 2019-05-30 at 8.04.50 PM.png (854×434 px, 196 KB)

✅ AC5: ensure links work on overflow menu

eswikiarwikiidwiki
All links above work.All links above work.All links above work.

✅ AC6: note anything that looks out of place

eswikiarwikiidwiki
Nothing out of place.Nothing out of place.Nothing out of place.

✅ AC7: test opening and closing the menu on a couple of devices

eswikiarwikiidwiki
iPhone XRiPhone XRiPhone XR
Galaxy S9Galaxy S9Galaxy S9