Page MenuHomePhabricator
Create Task
Maniphest T223915

Changes preview not working when editing older version of an article in 2017 wikitext editor
Closed, DuplicatePublic
Actions

Description

Steps to reproduce:

  1. enable 2017 wikitext editor in Beta settings
  2. open an article on any language-version of Wikipedia
  3. go to the revision history
  4. find an older version of the article, and click the date next to it to open it
  5. click on Edit to open the older version of the article in the 2017 wikitext editor (note: don't make any changes to the older version)
  6. click Publish changes, and then Review your changes

Expected result: the editor should list all changes made to the article in revisions newer than the opened one as being removed

Actual result: the editor says there are no changes

Additional information: if you go through the same steps, but using the old wikitext editor, clicking Show changes would give the expected result. I attached a screenshot of the actual and expected results.

2017-wikieditor-bug.png (2×1 px, 246 KB)

Related Objects

Event Timeline

Hmxhmx created this task.May 20 2019, 3:07 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptMay 20 2019, 3:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex added a subscriber: matmarex.May 21 2019, 2:02 AM

I believe we show changes compared to the revision you started editing, rather than to the article's most recent revision. This is consistent with how visual diff in the same dialog works, but inconsistent with the classic wikitext editor. I feel like there was another task discussing this, but I can't find it right now.

Hmxhmx added a comment.May 21 2019, 8:32 AM

Though wouldn't it be better to show the actual changes that will be made after saving the page, i.e. what the classic editor shows?

JTannerWMF moved this task from To Triage to Freezer on the VisualEditor board.May 21 2019, 3:10 PM
matmarex added a comment.May 22 2019, 8:04 PM

Maybe… I don't think that is obviously better. And it has its own set of issues (for example, if someone else edits the page in the meantime, the diff shown by the classic editor is not what is actually going to be saved, because of automatic edit conflict resolution).

Related: T121185 (which is basically a request to change wikitext editor behavior to match ours)

matmarex added a comment.May 22 2019, 9:20 PM
In T223915#5199193, @matmarex wrote:

I feel like there was another task discussing this, but I can't find it right now.

I might have been thinking of this conversation, now copied to a Phab comment: T121185#5206458

Galobtter added a subscriber: Galobtter.Jun 24 2019, 7:40 PM
matmarex closed this task as a duplicate of T203879: When editing an old version of a page, the VisualEditor shows the diff to that old version and not to the most recent version.Jul 2 2019, 6:14 PM
In T223915#5206624, @matmarex wrote:
In T223915#5199193, @matmarex wrote:

I feel like there was another task discussing this, but I can't find it right now.

I might have been thinking of this conversation, now copied to a Phab comment: T121185#5206458

I found the task I was thinking about :) and merged this one into it.

matmarex mentioned this in T203879: When editing an old version of a page, the VisualEditor shows the diff to that old version and not to the most recent version.Jul 2 2019, 6:16 PM
matmarex mentioned this in T315716: Visual editor diff behavior is different from wikitext editor behavior when editing an old revision (diff to start revision vs latest revision).Aug 20 2022, 2:15 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL