Page MenuHomePhabricator

Changes preview not working when editing older version of an article in 2017 wikitext editor
Closed, DuplicatePublic

Description

Steps to reproduce:

  1. enable 2017 wikitext editor in Beta settings
  2. open an article on any language-version of Wikipedia
  3. go to the revision history
  4. find an older version of the article, and click the date next to it to open it
  5. click on Edit to open the older version of the article in the 2017 wikitext editor (note: don't make any changes to the older version)
  6. click Publish changes, and then Review your changes

Expected result: the editor should list all changes made to the article in revisions newer than the opened one as being removed

Actual result: the editor says there are no changes

Additional information: if you go through the same steps, but using the old wikitext editor, clicking Show changes would give the expected result. I attached a screenshot of the actual and expected results.

2017-wikieditor-bug.png (2×1 px, 246 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I believe we show changes compared to the revision you started editing, rather than to the article's most recent revision. This is consistent with how visual diff in the same dialog works, but inconsistent with the classic wikitext editor. I feel like there was another task discussing this, but I can't find it right now.

Though wouldn't it be better to show the actual changes that will be made after saving the page, i.e. what the classic editor shows?

Maybe… I don't think that is obviously better. And it has its own set of issues (for example, if someone else edits the page in the meantime, the diff shown by the classic editor is not what is actually going to be saved, because of automatic edit conflict resolution).

Related: T121185 (which is basically a request to change wikitext editor behavior to match ours)

I feel like there was another task discussing this, but I can't find it right now.

I might have been thinking of this conversation, now copied to a Phab comment: T121185#5206458

I feel like there was another task discussing this, but I can't find it right now.

I might have been thinking of this conversation, now copied to a Phab comment: T121185#5206458

I found the task I was thinking about :) and merged this one into it.