Page MenuHomePhabricator
Create Task
Maniphest T223933

Database error when moving pages: LinksUpdate::updateCategoryCounts does not have outer scope.
Closed, DuplicatePublicPRODUCTION ERROR
Actions

Description

I just tried to execute some page moves, and 2 of them didn't work properly, requiring that I try again. For both, I set it to move the leave a redirect, add the pages to my watchlist, and move the talk page as well.
This move (and moving the talk page) originally resulted in [XOMFjQpAMFAAAJASGokAAABV] 2019-05-20 19:52:48: Fatal exception of type "Wikimedia\Rdbms\DBQueryError"

This move (and moving the talk page) originally result in [XOMFjgpAAEYAAHrYjRMAAAAK] 2019-05-20 19:52:48: Fatal exception of type "Wikimedia\Rdbms\DBQueryError"

Related Objects

Event Timeline

DannyS712 created this task.May 20 2019, 7:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2019, 7:57 PM
Marostegui edited projects, added: MediaWiki-libs-Rdbms, Platform Engineering; removed: DBA.May 20 2019, 8:10 PM
Marostegui subscribed.

The error itself:

Wikimedia\Rdbms\LBFactory::commitAndWaitForReplication: LinksUpdate::updateCategoryCounts does not have outer scope.
#0 /srv/mediawiki/php-1.34.0-wmf.5/includes/deferred/LinksUpdate.php(418): Wikimedia\Rdbms\LBFactory->commitAndWaitForReplication('LinksUpdate::up...', NULL, Array)
#1 /srv/mediawiki/php-1.34.0-wmf.5/includes/deferred/LinksUpdate.php(311): LinksUpdate->updateCategoryCounts(Array, Array)
#2 /srv/mediawiki/php-1.34.0-wmf.5/includes/deferred/LinksUpdate.php(189): LinksUpdate->doIncrementalUpdate()
#3 /srv/mediawiki/php-1.34.0-wmf.5/includes/Storage/DerivedPageDataUpdater.php(1622): LinksUpdate->doUpdate()
#4 /srv/mediawiki/php-1.34.0-wmf.5/includes/Storage/DerivedPageDataUpdater.php(1429): MediaWiki\Storage\DerivedPageDataUpdater->doSecondaryDataUpdates(Array)
#5 /srv/mediawiki/php-1.34.0-wmf.5/includes/deferred/MWCallableUpdate.php(34): MediaWiki\Storage\DerivedPageDataUpdater->MediaWiki\Storage\{closure}()
#6 /srv/mediawiki/php-1.34.0-wmf.5/includes/deferred/DeferredUpdates.php(274): MWCallableUpdate->doUpdate()
#7 /srv/mediawiki/php-1.34.0-wmf.5/includes/deferred/DeferredUpdates.php(219): DeferredUpdates::runUpdate(Object(MWCallableUpdate), Object(Wikimedia\Rdbms\LBFactoryMulti), 'run', 2)
#8 /srv/mediawiki/php-1.34.0-wmf.5/includes/deferred/DeferredUpdates.php(143): DeferredUpdates::execute(Array, 'run', 2)
#9 /srv/mediawiki/php-1.34.0-wmf.5/includes/MediaWiki.php(907): DeferredUpdates::doUpdates('run')
#10 /srv/mediawiki/php-1.34.0-wmf.5/includes/MediaWiki.php(731): MediaWiki->restInPeace('normal', false)
#11 /srv/mediawiki/php-1.34.0-wmf.5/includes/MediaWiki.php(754): MediaWiki->{closure}()
#12 /srv/mediawiki/php-1.34.0-wmf.5/includes/MediaWiki.php(548): MediaWiki->doPostOutputShutdown('normal')
#13 /srv/mediawiki/php-1.34.0-wmf.5/index.php(42): MediaWiki->run()
#14 /srv/mediawiki/w/index.php(3): require('/srv/mediawiki/...')
#15 {main}
Wikimedia\Rdbms\LBFactory::commitAndWaitForReplication: LinksUpdate::updateCategoryCounts does not have outer scope.
#0 /srv/mediawiki/php-1.34.0-wmf.5/includes/deferred/LinksUpdate.php(418): Wikimedia\Rdbms\LBFactory->commitAndWaitForReplication('LinksUp
Reedy added a project: Wikimedia-production-error.May 20 2019, 9:38 PM
Krinkle moved this task from Untriaged to May 2019 / 1.34.wmf.5+ on the Wikimedia-production-error board.May 20 2019, 9:39 PM
Aklapper renamed this task from Database error when moving pages to Database error when moving pages: LinksUpdate::updateCategoryCounts does not have outer scope..May 20 2019, 10:52 PM
Marostegui added a comment.May 21 2019, 5:31 AM

Not sure if this might be related or the same thing T221595: MovePage::move contention on cebwiki

• kchapman triaged this task as Medium priority.May 21 2019, 12:40 PM
• kchapman edited projects, added: Performance-Team, Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Platform Team Workboards; removed: Platform Engineering.
• kchapman added subscribers: aaron, • kchapman.

@aaron could you take a look when you get a chance?

• kchapman moved this task from Not a real column to Ready on the Platform Team Workboards board.May 21 2019, 12:40 PM
daniel subscribed.May 22 2019, 9:12 AM

This looks similar at a glance: T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not have outer scope

daniel added a comment.May 24 2019, 12:28 PM

Maybe this will fix the issue? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/497537

Seems to be failing CI for wikibase, though: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/497443/

Krinkle closed this task as a duplicate of T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not have outer scope.May 28 2019, 8:05 PM
Krinkle subscribed.

Yeah, same thing.

DannyS712 moved this task from Unsorted to Otherwise closed on the User-DannyS712 board.Jun 21 2019, 10:12 PM
• WDoranWMF moved this task from Ready to Done with CPT on the Platform Team Workboards board.Jul 5 2019, 3:21 PM
• WDoranWMF edited projects, added: Platform Team Workboards (Done with CPT); removed: Platform Team Workboards.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits