Page MenuHomePhabricator
Create Task
Maniphest T224025

Migrate existing projects to use the new Validator framework
Closed, ResolvedPublic
Actions

Description

With the new Validator framework being introduced we can start migrating existing projects that use MessageCheckers to use that instead it.

Initially a handful of projects had been chosen for initial migration,

  • iNaturalist
  • Dissem
  • Open Street Map - Website
  • WMCZ-Tracker

This process involves,

  • Migrating the existing checkers
  • Identifying any more checkers that need to be added
  • Migrating the Insertables
  • Deploying changes on Translatewiki.net
  • Getting feedback from the project

Another important goal is to have as less PHP code in the groups folder as possible.

The above migration went well, and we are now working on migrating the rest of the projects.

Details

Due Date
Feb 19 2020, 6:30 PM
SubjectRepoBranchLines +/-
Update Printf validator to match more formatsmediawiki/extensions/Translatemaster+17 -1
Replace checkers in MediaWiki, extension and themes with validatorstranslatewikimaster+30 -42
Add WikiLinkValidator and MediaWikiPageNameValidatormediawiki/extensions/Translatemaster+248 -0
Replace checkers and suggesters with validator for EtherpadLitetranslatewikimaster+5 -55
Replace checkers and suggesters with validator for MathJaxtranslatewikimaster+19 -66
Add validators for the Dissemin papers and websitetranslatewikimaster+21 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT195760 Language Annual Plan 2018-2019
 ResolvedNikerabbitT204818 Language tools maintenance intervention: Improve the quality of translations for Translate extension
 Resolvedabi_T204568 Extend message checker framework to support errors that prevent saving
 Resolvedabi_T224025 Migrate existing projects to use the new Validator framework
 ResolvedNikerabbitT231181 Add PLURAL validators for projects using the new Validator framework
 Declinedabi_T231657 Switch to using the new validator framework for iNaturalist project
 Resolvedabi_T231659 Switch to using the new validator framework for Open Street Map - Website project
 Resolvedabi_T231661 Switch to using the new validator framework for WMCZ-Tracker project
 Resolvedabi_T231658 Switch to using the new validator framework for Dissemin project
 Resolvedabi_T237907 Migrate Blockly to the new validator framework
 Resolvedabi_T237908 Migrate FreeCol to the new validator framework
 Resolvedabi_T237909 Migrate FUDForm to the new validator framework
 ResolvedCrutishnykT237910 Migrate Huggle to the new validator framework
 Resolvedabi_T237914 Migrate MAZI to the new validator framework
 Resolvedabi_T237916 Migrate Mifos to the new validator framework
 Resolvedabi_T237918 Migrate Nocc to the new validator framework
 ResolvedCrutishnykT237921 Migrate Phabricator to the new validator framework
 Resolvedabi_T237922 Migrate Pywikibot to the new validator framework
 Resolvedabi_T237919 Migrate Oppia to the new validator framework
 Resolvedabi_T239167 Migrate Citation hunt to the new validator framework
 Resolvedabi_T239216 Migrate Internet Archive Bot to the new validator framework
 ResolvedKizuleT239222 Migrate video2commons to the new validator framework
 Resolvedabi_T239247 Migrate Wikipedia Library Card Platform to the new validator framework
 ResolvedCrutishnykT239245 Migrate Wiki Ed Dashboard to the new validator framework
 Resolvedabi_T244829 Migrate MantisBT to the new validator framework
 Resolvedabi_T244830 Migrate GapFinder to the new validator framework
 Resolvedabi_T244832 Migrate Wikimedia projects to the new validator framework
 Resolvedabi_T244835 Migrate WikimediaTools to the new validator framework
 Resolvedabi_T244865 Migrate Wikimedia Android mobile to the new validator framework
 Resolvedabi_T244867 Migrate lib.reviews to the new validator framework

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Jul 16 2019, 2:35 PM

Change 523725 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Adds validators for iNaturalist

https://gerrit.wikimedia.org/r/523725

Nikerabbit added a comment.Jul 21 2019, 10:28 AM

While working on https://gerrit.wikimedia.org/r/c/translatewiki/+/524669 I observed two things:

  • Limiting the validator to only certain messages is not possible without PHP code. We should consider whether we can add a message key matching support.
  • Limiting insertables to only certain messages is not possible at all. Hence the MM|DD|YYYY validator is not currently showing them as insertables.
abi_ added a subtask: T231181: Add PLURAL validators for projects using the new Validator framework.Aug 26 2019, 4:45 AM
abi_ mentioned this in T230302: Internationalize JavaScript messages.Aug 26 2019, 5:50 AM
abi_ updated the task description. (Show Details)
gerritbot added a comment.Aug 29 2019, 2:52 PM

Change 519783 merged by jenkins-bot:
[translatewiki@master] Add validators for the Dissemin papers and website

https://gerrit.wikimedia.org/r/519783

jenkins-bot mentioned this in rGTWNd9ceb45f4fe6: Add validators for the Dissemin papers and website.Aug 29 2019, 2:55 PM
abi_ added a subtask: T231657: Switch to using the new validator framework for iNaturalist project.Aug 30 2019, 3:34 PM
abi_ mentioned this in T231657: Switch to using the new validator framework for iNaturalist project.
abi_ mentioned this in T231658: Switch to using the new validator framework for Dissemin project.Aug 30 2019, 3:40 PM
abi_ added a subtask: T231659: Switch to using the new validator framework for Open Street Map - Website project.Aug 30 2019, 3:44 PM
abi_ mentioned this in T231659: Switch to using the new validator framework for Open Street Map - Website project.
abi_ added a subtask: T231661: Switch to using the new validator framework for WMCZ-Tracker project.Aug 30 2019, 3:49 PM
abi_ added a subtask: T231658: Switch to using the new validator framework for Dissemin project.
abi_ updated the task description. (Show Details)Aug 30 2019, 3:53 PM
abi_ added a subtask: T231705: Limit validation to certain messages.Aug 31 2019, 5:11 AM
abi_ removed a subtask: T231705: Limit validation to certain messages.
abi_ added a comment.Aug 31 2019, 5:28 AM
In T224025#5351478, @Nikerabbit wrote:

While working on https://gerrit.wikimedia.org/r/c/translatewiki/+/524669 I observed two things:

  • Limiting the validator to only certain messages is not possible without PHP code. We should consider whether we can add a message key matching support.
  • Limiting insertables to only certain messages is not possible at all. Hence the MM|DD|YYYY validator is not currently showing them as insertables.

I have created the task T231705: Limit validation to certain messages to track this.

abi_ closed subtask T231658: Switch to using the new validator framework for Dissemin project as Resolved.Sep 18 2019, 4:37 PM
abi_ closed subtask T231657: Switch to using the new validator framework for iNaturalist project as Declined.Sep 19 2019, 8:18 AM
abi_ closed subtask T231661: Switch to using the new validator framework for WMCZ-Tracker project as Resolved.Sep 25 2019, 2:57 PM
Pginer-WMF edited projects, added Language-Team (Language-2019-October-December); removed Language-Team (Language-2019-July-September).Oct 9 2019, 11:52 AM
Pginer-WMF moved this task from Backlog to In Progress on the Language-Team (Language-2019-October-December) board.
abi_ added a comment.Nov 5 2019, 5:59 AM

I've made a list of projects still using the old CHECKER syntax by running the following command,

❯ grep -H -R "CHECKER" groups/**/*.yaml | cut -d: -f1

I've pasted the output here - P9529. Check the output under Projects using CHECKER heading.

Nikerabbit moved this task from Backlog to Features on the translatewiki.net board.Nov 5 2019, 4:06 PM
gerritbot added a comment.Nov 8 2019, 8:59 PM

Change 549930 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Replace checkers and suggesters with validator for EtherpadLite

https://gerrit.wikimedia.org/r/549930

gerritbot added a comment.Nov 9 2019, 6:45 AM

Change 549964 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Replace checkers and suggesters with validator for MathJax

https://gerrit.wikimedia.org/r/549964

gerritbot added a comment.Nov 9 2019, 8:35 PM

Change 549964 merged by jenkins-bot:
[translatewiki@master] Replace checkers and suggesters with validator for MathJax

https://gerrit.wikimedia.org/r/549964

abi_ mentioned this in rGTWNf13942bf5666: Replace checkers and suggesters with validator for MathJax.Nov 9 2019, 8:35 PM
abi_ added a subtask: T237907: Migrate Blockly to the new validator framework.Nov 11 2019, 7:40 AM
abi_ added a subtask: T237909: Migrate FUDForm to the new validator framework.Nov 11 2019, 7:54 AM
abi_ added a subtask: T237910: Migrate Huggle to the new validator framework.Nov 11 2019, 8:10 AM
abi_ added a subtask: T237914: Migrate MAZI to the new validator framework.
abi_ added a subtask: T237916: Migrate Mifos to the new validator framework.Nov 11 2019, 8:17 AM
abi_ added a subtask: T237918: Migrate Nocc to the new validator framework.Nov 11 2019, 8:26 AM
abi_ added a subtask: T237921: Migrate Phabricator to the new validator framework.Nov 11 2019, 8:32 AM
abi_ added a subtask: T237922: Migrate Pywikibot to the new validator framework.Nov 11 2019, 8:41 AM
abi_ added a subtask: T237919: Migrate Oppia to the new validator framework.
gerritbot added a comment.Nov 12 2019, 4:51 PM

Change 549930 merged by jenkins-bot:
[translatewiki@master] Replace checkers and suggesters with validator for EtherpadLite

https://gerrit.wikimedia.org/r/549930

jenkins-bot mentioned this in rGTWN892708f21f06: Replace checkers and suggesters with validator for EtherpadLite.Nov 12 2019, 4:52 PM
abi_ set Due Date to Dec 30 2019, 6:30 PM.Nov 14 2019, 4:24 PM
abi_ added a subtask: T239167: Migrate Citation hunt to the new validator framework.Nov 26 2019, 9:51 AM
abi_ added a subtask: T239216: Migrate Internet Archive Bot to the new validator framework.Nov 26 2019, 10:53 AM
abi_ added a subtask: T239222: Migrate video2commons to the new validator framework.Nov 26 2019, 11:40 AM
abi_ added a subtask: T239247: Migrate Wikipedia Library Card Platform to the new validator framework.Nov 26 2019, 4:35 PM
abi_ added a subtask: T239245: Migrate Wiki Ed Dashboard to the new validator framework.Nov 26 2019, 4:39 PM
abi_ closed subtask T237907: Migrate Blockly to the new validator framework as Resolved.Dec 11 2019, 12:08 PM
abi_ closed subtask T237921: Migrate Phabricator to the new validator framework as Resolved.Dec 13 2019, 1:34 PM
abi_ renamed this task from Migrate a few projects to the new Validator framework to Migrate existing projects to use the new Validator framework.Dec 13 2019, 4:08 PM
abi_ updated the task description. (Show Details)
abi_ closed subtask T237919: Migrate Oppia to the new validator framework as Resolved.Dec 14 2019, 2:25 PM
abi_ closed subtask T239222: Migrate video2commons to the new validator framework as Resolved.Dec 15 2019, 1:06 PM
abi_ closed subtask T237918: Migrate Nocc to the new validator framework as Resolved.Dec 18 2019, 2:59 PM
abi_ closed subtask T237910: Migrate Huggle to the new validator framework as Resolved.Dec 18 2019, 10:15 PM
abi_ closed subtask T239245: Migrate Wiki Ed Dashboard to the new validator framework as Resolved.Dec 26 2019, 6:32 PM
Pginer-WMF edited projects, added Language-Team (Language-2020-January-March); removed Language-Team (Language-2019-October-December).Jan 2 2020, 8:12 AM
Pginer-WMF moved this task from Backlog to In Progress on the Language-Team (Language-2020-January-March) board.
abi_ changed Due Date from Dec 30 2019, 6:30 PM to Jan 30 2020, 6:30 PM.Jan 6 2020, 5:19 AM
abi_ closed subtask T231659: Switch to using the new validator framework for Open Street Map - Website project as Resolved.Jan 13 2020, 2:41 AM
abi_ closed subtask T231181: Add PLURAL validators for projects using the new Validator framework as Resolved.
Nikerabbit closed subtask T237908: Migrate FreeCol to the new validator framework as Resolved.Jan 15 2020, 2:09 PM
abi_ changed Due Date from Jan 30 2020, 6:30 PM to Feb 19 2020, 6:30 PM.Feb 2 2020, 11:54 AM
abi_ removed a project: User-abi_.
gerritbot added a comment.Feb 2 2020, 4:41 PM

Change 569367 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Add WikiLinkValidator and MediaWikiPageNameValidator

https://gerrit.wikimedia.org/r/569367

gerritbot added a comment.Feb 2 2020, 5:55 PM

Change 569371 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Replace checkers in MediaWiki, extension and themes with validators

https://gerrit.wikimedia.org/r/569371

gerritbot added a comment.Feb 10 2020, 7:15 AM

Change 569367 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add WikiLinkValidator and MediaWikiPageNameValidator

https://gerrit.wikimedia.org/r/569367

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 10 2020, 8:01 AM
abi_ closed subtask T237916: Migrate Mifos to the new validator framework as Resolved.Feb 10 2020, 9:56 AM
abi_ closed subtask T239247: Migrate Wikipedia Library Card Platform to the new validator framework as Resolved.
abi_ closed subtask T239167: Migrate Citation hunt to the new validator framework as Resolved.Feb 10 2020, 10:00 AM
abi_ closed subtask T239216: Migrate Internet Archive Bot to the new validator framework as Resolved.Feb 10 2020, 11:53 AM
abi_ closed subtask T237914: Migrate MAZI to the new validator framework as Resolved.
abi_ closed subtask T237909: Migrate FUDForm to the new validator framework as Resolved.Feb 10 2020, 11:57 AM
Kizule closed subtask T237922: Migrate Pywikibot to the new validator framework as Resolved.Feb 10 2020, 11:57 AM
abi_ added a comment.EditedFeb 11 2020, 5:01 AM

Remaining projects using Message checkers,

❯ grep -H -R "CHECKER" groups/**/*.yaml | cut -d: -f1
groups/MantisBT/MantisBT.yaml
groups/Wikimedia/GapFinder.yaml
groups/Wikimedia/global-search.yaml
groups/Wikimedia/GrantMetrics.yaml
groups/Wikimedia/InteractionTimeline.yaml
groups/Wikimedia/Pageviews.yaml
groups/Wikimedia/ProveIt.yaml
groups/Wikimedia/svgtranslate.yaml
groups/Wikimedia/wiki-ai.yaml
groups/Wikimedia/WikimediaMobile-android.yaml
groups/Wikimedia/WikimediaTools.yaml
groups/Wikimedia/wscontest.yaml
groups/Wikimedia/XTools.yaml

Remaining projects using custom Insertable suggester,

❯ grep -H -R "Suggester.php" groups/**/*.yaml 
groups/lib.reviews/lib.reviews.yaml:  LibReviewsInsertablesSuggester: LibReviewsInsertablesSuggester.php
groups/MantisBT/MantisBT.yaml:  MantisBTInsertablesSuggester: MantisBTInsertablesSuggester.php
groups/Wikimedia/WikimediaMobile-android.yaml:    WikimediaMobileAndroidInsertablesSuggester: WikimediaMobileAndroidSuggester.php
groups/Wikimedia/WikimediaTools.yaml:  CrosswatchInsertablesSuggester: crosswatchSuggester.php
abi_ moved this task from In Progress to In Review on the Language-Team (Language-2020-January-March) board.Feb 12 2020, 2:46 AM

All the projects have now been migrated to use the new validator framework, and all the tasks are now in review.

gerritbot added a comment.Feb 12 2020, 2:35 PM

Change 569371 merged by jenkins-bot:
[translatewiki@master] Replace checkers in MediaWiki, extension and themes with validators

https://gerrit.wikimedia.org/r/569371

jenkins-bot mentioned this in rGTWN3bd53e12c7bd: Replace checkers in MediaWiki, extension and themes with validators.Feb 12 2020, 2:37 PM
Kizule closed subtask T244830: Migrate GapFinder to the new validator framework as Resolved.Feb 12 2020, 2:56 PM
Kizule closed subtask T244829: Migrate MantisBT to the new validator framework as Resolved.
gerritbot added a comment.Feb 21 2020, 6:05 AM

Change 573854 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Update Printf validator to match more formats

https://gerrit.wikimedia.org/r/573854

gerritbot added a comment.Feb 21 2020, 8:27 AM

Change 573854 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Update Printf validator to match more formats

https://gerrit.wikimedia.org/r/573854

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.21; 2020-02-25); removed MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 21 2020, 9:00 AM
Kizule closed subtask T244867: Migrate lib.reviews to the new validator framework as Resolved.Feb 25 2020, 9:20 AM
Kizule closed subtask T244835: Migrate WikimediaTools to the new validator framework as Resolved.
Nikerabbit reopened subtask T244835: Migrate WikimediaTools to the new validator framework as Open.Feb 25 2020, 10:30 AM
Nikerabbit closed subtask T244865: Migrate Wikimedia Android mobile to the new validator framework as Resolved.Feb 26 2020, 2:27 PM
Nikerabbit closed this task as Resolved.Feb 26 2020, 2:57 PM
Nikerabbit removed a project: Patch-For-Review.
Nikerabbit moved this task from In Review to Done on the Language-Team (Language-2020-January-March) board.
abi_ closed subtask T244835: Migrate WikimediaTools to the new validator framework as Resolved.Mar 4 2020, 4:37 PM
abi_ closed subtask T244832: Migrate Wikimedia projects to the new validator framework as Resolved.Mar 4 2020, 4:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits