Page MenuHomePhabricator

Migrate existing projects to use the new Validator framework
Open, MediumPublic

Description

With the new Validator framework being introduced we can start migrating existing projects that use MessageCheckers to use that instead it.

Initially a handful of projects had been chosen for initial migration,

  • iNaturalist
  • Dissem
  • Open Street Map - Website
  • WMCZ-Tracker

This process involves,

  • Migrating the existing checkers
  • Identifying any more checkers that need to be added
  • Migrating the Insertables
  • Deploying changes on Translatewiki.net
  • Getting feedback from the project

Another important goal is to have as less PHP code in the groups folder as possible.

The above migration went well, and we are now working on migrating the rest of the projects.

Details

Due Date
Thu, Jan 30, 6:30 PM
Related Gerrit Patches:

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
Resolvedabi_
Openabi_
ResolvedNikerabbit
Declinedabi_
Resolvedabi_
Resolvedabi_
Resolvedabi_
Resolvedabi_
Resolvedabi_
OpenNone
ResolvedCrutishnyk
OpenNone
OpenNone
Resolvedabi_
ResolvedCrutishnyk
OpenNone
Resolvedabi_
OpenNone
OpenNone
ResolvedZoranzoki21
OpenNone
ResolvedCrutishnyk

Event Timeline

abi_ created this task.May 21 2019, 2:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2019, 2:18 PM
abi_ updated the task description. (Show Details)May 23 2019, 12:39 PM
abi_ moved this task from Backlog to In Progress on the User-abi_ board.Jun 28 2019, 7:44 AM

Change 519783 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Adds validators for the Dissem papers and website

https://gerrit.wikimedia.org/r/519783

abi_ updated the task description. (Show Details)Jun 30 2019, 11:03 AM
Pginer-WMF triaged this task as Medium priority.Jul 1 2019, 10:50 AM
abi_ updated the task description. (Show Details)Jul 9 2019, 6:08 AM

Change 523725 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Adds validators for iNaturalist

https://gerrit.wikimedia.org/r/523725

While working on https://gerrit.wikimedia.org/r/c/translatewiki/+/524669 I observed two things:

  • Limiting the validator to only certain messages is not possible without PHP code. We should consider whether we can add a message key matching support.
  • Limiting insertables to only certain messages is not possible at all. Hence the MM|DD|YYYY validator is not currently showing them as insertables.

Change 519783 merged by jenkins-bot:
[translatewiki@master] Add validators for the Dissemin papers and website

https://gerrit.wikimedia.org/r/519783

abi_ updated the task description. (Show Details)Aug 30 2019, 3:53 PM
abi_ added a comment.Aug 31 2019, 5:28 AM

While working on https://gerrit.wikimedia.org/r/c/translatewiki/+/524669 I observed two things:

  • Limiting the validator to only certain messages is not possible without PHP code. We should consider whether we can add a message key matching support.
  • Limiting insertables to only certain messages is not possible at all. Hence the MM|DD|YYYY validator is not currently showing them as insertables.

I have created the task T231705: Limit validation to certain messages to track this.

abi_ added a comment.Nov 5 2019, 5:59 AM

I've made a list of projects still using the old CHECKER syntax by running the following command,

❯ grep -H -R "CHECKER" groups/**/*.yaml | cut -d: -f1

I've pasted the output here - P9529. Check the output under Projects using CHECKER heading.

Nikerabbit moved this task from Backlog to Features on the translatewiki.net board.Nov 5 2019, 4:06 PM

Change 549930 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Replace checkers and suggesters with validator for EtherpadLite

https://gerrit.wikimedia.org/r/549930

Change 549964 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Replace checkers and suggesters with validator for MathJax

https://gerrit.wikimedia.org/r/549964

Change 549964 merged by jenkins-bot:
[translatewiki@master] Replace checkers and suggesters with validator for MathJax

https://gerrit.wikimedia.org/r/549964

Change 549930 merged by jenkins-bot:
[translatewiki@master] Replace checkers and suggesters with validator for EtherpadLite

https://gerrit.wikimedia.org/r/549930

abi_ set Due Date to Mon, Dec 30, 6:30 PM.Nov 14 2019, 4:24 PM
abi_ renamed this task from Migrate a few projects to the new Validator framework to Migrate existing projects to use the new Validator framework.Dec 13 2019, 4:08 PM
abi_ updated the task description. (Show Details)
abi_ changed Due Date from Mon, Dec 30, 6:30 PM to Thu, Jan 30, 6:30 PM.Mon, Jan 6, 5:19 AM