Page MenuHomePhabricator

Add database implementation of TypeIdsAcquirer
Closed, ResolvedPublic

Description

Currently, the only implementation of TypeIdsAcquirer we have is InMemoryTypeIdsAcquirer. Clearly, we’ll need a database version as well.

Patch-For-Review: https://github.com/wmde/mediawiki-term-store/pull/28

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2019, 4:09 PM

We decided this implementation will live in Wikibase, so that it can use the NameTableStore class. The library will only provide the TypeIdsAcquirer and TypeIdsResolver interfaces, but won’t know anything about the wbt_type table.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Change 511916 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add SqlTypeIdsStore implementation

https://gerrit.wikimedia.org/r/511916

Change 512378 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add SqlTypeIdsStore implementation

https://gerrit.wikimedia.org/r/512378

Change 512378 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add SqlTypeIdsStore implementation

https://gerrit.wikimedia.org/r/512378

alaa_wmde added a subscriber: alaa_wmde.

Change https://gerrit.wikimedia.org/r/511916 is probably need to be abandoned .. keeping this in done until it is checked, otherwise it can be resolved as the other change is merged already

Change 511916 abandoned by Lucas Werkmeister (WMDE):
Add SqlTypeIdsStore implementation

Reason:
superseded by I16e73a5a39

https://gerrit.wikimedia.org/r/511916

Lucas_Werkmeister_WMDE closed this task as Resolved.Jun 3 2019, 11:31 AM