Drag and drop of focusable nodes no longer works in Visual Editor
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Aschmidt
	May 21 2019, 4:54 PM

Description

Steps to Reproduce: Run Firefox 66.0.5 on macOS 10.13.6. Open an article on German Wikipedia with Visual Editor and (1) select a footnote, or (2) select some phrase of text and try to move it by drag and drop.

Actual Results: The footnote won't move, while the phrase will move.

Expected Results: In both cases you would expect to be able to drag and drop these elements of text. AFAIR it was possible to move footnotes like this until recently.

Sorry if this should have been reported before, I didn't find any bug that fits in here.

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (e3715c257)	mediawiki/extensions/VisualEditor	master	+1 -1
	Revert "ve.ce.FocusableNode: Prevent native selection from changing on click"	VisualEditor/VisualEditor	master	+14 -15

Customize query in gerrit

Related Objects

Mentioned In: T108013: [CX2] Pressing backspace from the uneditable reference section takes user back in the tab
Mentioned Here: rGVEDe3715c2574a2: Merge "Revert "ve.ce.FocusableNode: Prevent native selection from changing on…

Event Timeline

Aschmidt created this task.May 21 2019, 4:54 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptMay 21 2019, 4:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Aschmidt updated the task description. (Show Details)May 21 2019, 4:55 PM

It is the same after updating to Firefox 67.0.

Hmm, looks like we broke all drag-drop. :/

Change 512538 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Revert "ve.ce.FocusableNode: Prevent native selection from changing on click"

https://gerrit.wikimedia.org/r/512538

gerritbot added a project: Patch-For-Review.May 26 2019, 5:25 PM

Esanders renamed this task from Drag and drop of footnotes no longer works in Visual Editor to Drag and drop of focusable nodes no longer works in Visual Editor.May 26 2019, 5:31 PM

Esanders added a project: Regression.

Esanders added a subscriber: matmarex.

matmarex mentioned this in T108013: [CX2] Pressing backspace from the uneditable reference section takes user back in the tab.May 27 2019, 6:14 PM

Change 512538 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Revert "ve.ce.FocusableNode: Prevent native selection from changing on click"

https://gerrit.wikimedia.org/r/512538

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.May 27 2019, 6:28 PM

matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.

matmarex removed a project: Patch-For-Review.

Change 512938 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e3715c257)

https://gerrit.wikimedia.org/r/512938

gerritbot added a project: Patch-For-Review.May 28 2019, 5:46 PM

Change 512938 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e3715c257)

https://gerrit.wikimedia.org/r/512938

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).May 28 2019, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 28 2019, 7:11 PM

Schnark merged a task: T225132: VisualEditor: Can no longer drag and drop (move) citations.Jun 6 2019, 7:17 AM

Schnark added a subscriber: SUM1.

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Jun 11 2019, 10:33 PM

Ryasmeen added a project: Verified.

For the record: I could use drag and drop with a footnote tonight for the first time again. :)

Thanks for the good work!