Page MenuHomePhabricator

Rate-limit requests in parsoid.js that use stashing
Closed, ResolvedPublic0 Story Points

Description

Now that we have stashing fully in place, there is one last piece to do. Because stashing is expensive (and it's a write-on-read), we may easily fill the storage with high request rates, so we have to implement a special case of rate limiting that pertains only to requests that use the stash=true query parameter.

Event Timeline

mobrovac triaged this task as High priority.May 21 2019, 6:03 PM
mobrovac created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2019, 6:03 PM
mobrovac claimed this task.May 23 2019, 9:52 AM
mobrovac added a subscriber: Pchelolo.

PR #1140 adds stashing-specific rate limiting to the Parsoid module.

Change 512181 had a related patch set uploaded (by Mobrovac; owner: Mobrovac):
[mediawiki/services/restbase/deploy@master] Config: Introduce stash_ratelimit

https://gerrit.wikimedia.org/r/512181

Change 512181 merged by Mobrovac:
[mediawiki/services/restbase/deploy@master] Config: Introduce stash_ratelimit

https://gerrit.wikimedia.org/r/512181

Mentioned in SAL (#wikimedia-operations) [2019-05-24T05:58:40Z] <mobrovac@deploy1001> Started deploy [restbase/deploy@b153f5d]: Remove Parsoid fallback and rate-limit stashing - T215956 T224055

Mentioned in SAL (#wikimedia-operations) [2019-05-24T06:20:11Z] <mobrovac@deploy1001> Finished deploy [restbase/deploy@b153f5d]: Remove Parsoid fallback and rate-limit stashing - T215956 T224055 (duration: 21m 30s)