Now that we have stashing fully in place, there is one last piece to do. Because stashing is expensive (and it's a write-on-read), we may easily fill the storage with high request rates, so we have to implement a special case of rate limiting that pertains only to requests that use the stash=true query parameter.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Config: Introduce `stash_ratelimit` | mediawiki/services/restbase/deploy | master | +2 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • WDoranWMF | T220449 Split RESTBase in two services: storage service and API router/proxy | |||
| Resolved | • mobrovac | T220461 Simplify storage semantics | |||
| Resolved | • Pchelolo | T215956 Consider stashing data-parsoid for VE | |||
| Resolved | • mobrovac | T224055 Rate-limit requests in parsoid.js that use stashing |
Event Timeline
Comment Actions
Change 512181 had a related patch set uploaded (by Mobrovac; owner: Mobrovac):
[mediawiki/services/restbase/deploy@master] Config: Introduce stash_ratelimit
Comment Actions
Change 512181 merged by Mobrovac:
[mediawiki/services/restbase/deploy@master] Config: Introduce stash_ratelimit
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2019-05-24T05:58:40Z] <mobrovac@deploy1001> Started deploy [restbase/deploy@b153f5d]: Remove Parsoid fallback and rate-limit stashing - T215956 T224055
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2019-05-24T06:20:11Z] <mobrovac@deploy1001> Finished deploy [restbase/deploy@b153f5d]: Remove Parsoid fallback and rate-limit stashing - T215956 T224055 (duration: 21m 30s)