Page MenuHomePhabricator
Create Task
Maniphest T224069

Add/reserve a Jenkins node for the pipeline's trigger jobs
Closed, ResolvedPublic
Actions

Description

Due to limitations with Zuul v2's scheduler, it can only only run freestyle Jenkins jobs. To work around this limitation, all pipeline jobs currently have a corresponding freestyle "trigger" job that passes along parameters and blocks, returning the result of the "real" pipeline job.

These trigger builds end up taking executors unnecessarily; They don't do any real work.

One solution for this issue might be to add a single node to Jenkins with a label (e.g. "trigger") that can be used to schedule trigger builds, keeping the other nodes free to do real work. This node might not even necessitate an additional instance as it won't incur substantial CPU usage. It could potentially be configured as a remote SSH node that logs in to an existing instance with a different user account for example.

Details

ProjectBranchLines +/-Subject
operations/puppetproduction+15 -1CI: Create lightweight agent role for Jenkins
integration/configmaster+4 -4pipeline: Add node for pipeline's trigger jobs
Customize query in gerrit

Event Timeline

dduvall created this task.May 21 2019, 10:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2019, 10:55 PM
dduvall updated the task description. (Show Details)May 21 2019, 10:59 PM
brennen added a subscriber: brennen.Jun 11 2019, 4:12 PM
thcipriani assigned this task to brennen.Jun 11 2019, 4:34 PM
thcipriani triaged this task as Medium priority.
thcipriani added a subscriber: thcipriani.

@brennen made the mistake of showing interest in this task, assigning accordingly :)

Stashbot added a comment.Jun 11 2019, 9:07 PM

Mentioned in SAL (#wikimedia-releng) [2019-06-11T21:07:50Z] <brennen> creating integration-trigger-01 for T224069

gerritbot added a comment.Jun 13 2019, 12:23 AM

Change 516723 had a related patch set uploaded (by Brennen Bearnes; owner: Brennen Bearnes):
[integration/config@master] pipeline: Add node for pipeline's trigger jobs

https://gerrit.wikimedia.org/r/516723

gerritbot added a project: Patch-For-Review.Jun 13 2019, 12:23 AM
gerritbot added a comment.Jun 13 2019, 3:53 PM

Change 516723 merged by jenkins-bot:
[integration/config@master] pipeline: Add node for pipeline's trigger jobs

https://gerrit.wikimedia.org/r/516723

brennen closed this task as Resolved.Jun 13 2019, 4:06 PM
hashar reopened this task as Open.Jun 13 2019, 4:45 PM
hashar added a subscriber: hashar.

The instance is a small one and all most of the disk is used by the / partition. When the extended disk is created, there is only 415MBytes left for `/srv:

$ df -h /srv
Filesystem                          Size  Used Avail Use% Mounted on
/dev/mapper/vd-second--local--disk  484M   41M  415M   9% /srv

Thus Shinken to alert about disk space :-\

With the puppet class role::ci::slave::labs applied, we got: role::ci::slave::labs::common > ::profile::labs::lvm::srv which does the extended disk.

My fault really, the role::ci::slave::labs class is legacy from when we had the instances provisioned with everything needed to run any job (php, debian packages, python, node etc). It is way too large.

Instead we would want to create a new role in puppet that is shrinken and just include jenkins::common. That should be sufficient. The home directory would be /mnt/home/jenkins-deploy which is not even a mount but on the / partition, that comes from LDAP and never got changed. The path has to be set in the Jenkins config for the slave.

So my bad really. You got hit by lot of Technical-Debt

brennen added a comment.Jun 13 2019, 4:52 PM

Just so I'm clear, in this instance is it sufficient to change workspace to /mnt/home/jenkins-deploy in the Jenkins config? I see that path exists.

hashar added a comment.Jun 13 2019, 4:57 PM
In T224069#5257019, @brennen wrote:

Just so I'm clear, in this instance is it sufficient to change workspace to /mnt/home/jenkins-deploy in the Jenkins config? I see that path exists.

Yes that would do it.

Then we need to use a puppet class that does not bring in ::profile::labs::lvm::srv which would require the creation of a new dummy role. Then one can change the role applied to the instance and unmount /srv/ \o/

Stashbot added a comment.Jun 13 2019, 5:05 PM

Mentioned in SAL (#wikimedia-releng) [2019-06-13T17:05:28Z] <brennen> changing jenkins remote root for integration-trigger-01 to /mnt/home/jenkins-deploy per T224069

Maintenance_bot removed a project: Patch-For-Review.Jun 13 2019, 5:10 PM
brennen added a comment.Jun 13 2019, 6:05 PM

Per conversation elsewhere, will pair with @thcipriani on the puppet role on Friday.

gerritbot added a comment.Jun 14 2019, 5:53 PM

Change 517111 had a related patch set uploaded (by Brennen Bearnes; owner: Brennen Bearnes):
[operations/puppet@production] CI: Create lightweight agent role for Jenkins

https://gerrit.wikimedia.org/r/517111

gerritbot added a project: Patch-For-Review.Jun 14 2019, 5:53 PM
gerritbot added a comment.Jun 19 2019, 2:22 PM

Change 517111 merged by Alexandros Kosiaris:
[operations/puppet@production] CI: Create lightweight agent role for Jenkins

https://gerrit.wikimedia.org/r/517111

Maintenance_bot removed a project: Patch-For-Review.Jun 19 2019, 3:10 PM
brennen closed this task as Resolved.Jun 24 2019, 3:54 PM
hashar added a comment.Jun 24 2019, 4:28 PM

I have unmounted /srv and removed it from /etc/fstab :)

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL