Page MenuHomePhabricator

[[Wikimedia:Global-search-total-results/en]]: incorrect use of PLURAL
Closed, ResolvedPublic

Description

The documentation says this is a "Label for value indicating the total number of results". In English (and in every other language I know anything about), such a label should be invariable, and say "Total results" even if the number of results is 1. That is, "total results" is just short for "total number of results", so "total result: 1" would be as wrong as "total number of result: 1".

Since some other languages may need PLURAL here, this should be changed to "Total {{PLURAL:$1|results}".


URL: https://translatewiki.net/wiki/Wikimedia:Global-search-total-results/ia

Event Timeline

The message seems to be in "global-search" hence adding project tag so its developers can find and see this task.

For the records, https://translatewiki.net/wiki/Wikimedia:Global-search-total-results/en currently says Total {{PLURAL:$1|result|results}}

MusikAnimal claimed this task.
MusikAnimal subscribed.

Good call, I've fixed this in https://github.com/MusikAnimal/global-search/commit/cdda821935da05c7fe501725636605a8fe5d581a

I only put PLURAL because I wasn't sure if other languages would need it. But you're right, for English, it should always be "results".