Page MenuHomePhabricator
Create Task
Maniphest T224085

WikiPEG: remove unnecessary variable assignment assertion mode
Open, LowPublic
Actions

Description

  • Change context.discard to context.asserted. "discard" is misleading, since we aren't really discarding anything
  • Change peg$discard to peg$check. Shorter and not misleading
  • Use "silence" instead of "discard" to refer to error suppression
  • No unnecessary variable assignment in assertion mode (currently only zero_or_more, one_or_more, and text checks for it)

Related Objects

Event Timeline

Dan1wang created this task.May 22 2019, 7:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 22 2019, 7:46 AM
gerritbot mentioned this in T224084: WikiPEG: Drop legacy (IE8) and unused code.May 22 2019, 7:52 AM

Change 511820 had a related patch set uploaded (by Dan1wang; owner: Dan1wang):
[wikipeg@master] Drop legacy & unused code (T224084). Avoid use of "discard" (T224085)

https://gerrit.wikimedia.org/r/511820

gerritbot added a project: Patch-For-Review.May 22 2019, 7:52 AM
tstarling subscribed.May 28 2019, 4:25 AM

It's not necessary to file a Phabricator ticket for every change. Just describe the change in the commit message.

ssastry triaged this task as Low priority.Jun 10 2019, 8:32 PM
ssastry edited projects, added WikiPEG; removed Parsoid.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL