Page MenuHomePhabricator

Wikibase and WikibaseLexeme Selenium tests fail when UseCirrus is true in WikibaseCirrusSearch
Open, MediumPublic

Description

WikibaseCirrusSearch has a UseCirrus config variable that currently defaults to false, disabling its functionality. This is a confusing default, and can create hassles for developers trying to set it up in a testing environment. It should default to true.

The trouble is that changing the default to true breaks several Selenium tests for the Wikibase and WikibaseLexeme extensions, as shown in the failing test jobs on https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseCirrusSearch/+/507597/. Adding a $wgWBCSUseCirrus = false; directive to tests/selenium/LocalSettings.php in WikibaseCirrusSearch does not resolve this problem, and based on my local testing, doing the same directly in Wikibase does not help, either.

Ultimately, we shouldn't be trying to work around the problem; the tests and CI environment should be able to accommodate WikibaseCirrusSearch.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Smalyshev triaged this task as Medium priority.Jun 4 2019, 6:52 AM

Ultimately, we shouldn't be trying to work around the problem; the tests and CI environment should be able to accommodate WikibaseCirrusSearch.

True, but for starters it'd be good if we could have some setting that disabled WBCS for the CI. We have Cindy bot that does a lot of testing for CirrusSearch parts, and we could have the same for WikidataCirrusSearch parts (see T223789) but since CI does not support the full extent of ElasticSearch operation yet, we may be ok with just keeping the status quo for a short term.

@zeljkofilipin Do we have or plan to have any way to solve this in the near term, like ability to load special config settings for CI?