Page MenuHomePhabricator

Refactor scroll into view to allow for generic padding
Closed, ResolvedPublic

Description

Currently we only account for the toolbar at the top of the page obscuring the content, but we may want to have a context at the bottom of the page on mobile.

There are also different code paths for scrolling the current selection into view and these should be unified.

Event Timeline

Esanders created this task.May 22 2019, 2:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 22 2019, 2:33 PM

Change 511891 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Replace surface's 'toolbarHeight' with generic 'padding'

https://gerrit.wikimedia.org/r/511891

Change 511895 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Replace call to setToolbarHeight with setPadding

https://gerrit.wikimedia.org/r/511895

Change 511891 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Replace surface's 'toolbarHeight' with generic 'padding'

https://gerrit.wikimedia.org/r/511891

Change 511921 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (120c96c94)

https://gerrit.wikimedia.org/r/511921

Change 511921 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c3d8228b8)

https://gerrit.wikimedia.org/r/511921

Change 511895 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Replace call to setToolbarHeight with setPadding

https://gerrit.wikimedia.org/r/511895

ppelberg closed this task as Resolved.Thu, Jun 27, 5:11 AM