Page MenuHomePhabricator

Visual Editor doesn't scroll/float properly when searching for Arabic text while editing (Chrome/Safari)
Open, Needs TriagePublic

Description

[Originally mistakenly reported on T140797]

I'm seeing a problem in Chrome (Version 74.0.3729.131 (Official Build) (64-bit) / OS X 10.13.6).

To reproduce:

  • Set browser window size to 1186 x 705
  • Open a private browser window (so as to be not logged in or have any other stuff enabled)
  • Edit this old version of the Arabic article with the English interface.
  • Click "Find and replace" from the Visual Editor menu
  • Search for في —there should be 99 results
  • Scroll all the way to the top of the page (exact location on the page seems to matter)
  • Click next result (">") lots of times....
    • #16 and #17 are barely on the screen (see screenshot)

The behavior at this point is inconsistent:

  • Sometimes result 18 and 19 show the problem behavior, and the screen does not scroll.
  • If result 18 does scroll, then you can click previous result ("<") back to result 9, and the screen does not scroll (though it is probably behind the find and replace UI element.

More generally, clicking forward and backward through at least 20 or 30 results at a time will eventually show the behavior of the highlighted result not being on screen.


Safari has a different problem.

  • Safari 12.1 on macOS (High Sierra)
  • Edit this old version of the Arabic article with the English interface.
  • Click "Find and replace" from the Visual Editor menu
  • Search for في —there should be 99 results
  • Click on the previous result ("<")
  • The screen scrolls down to the bottom of the page and the find and replace UI element is not floating—it's way back up at the top of the page.

Event Timeline

TJones created this task.May 22 2019, 6:41 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptMay 22 2019, 6:41 PM
Restricted Application added subscribers: alanajjar, Aklapper. · View Herald Transcript
  • Scroll all the way to the top of the page (exact location on the page seems to matter)
  • Click next result (">") lots of times....
    • #16 and #17 are barely on the screen (see screenshot)

This can also be reproduced in English, in this example on https://en.wikipedia.org/wiki/The_Fighting_Temeraire?veaction=edit:

Looks like the code in ve.ui.FindAndReplaceDialog.prototype.highlightFocused only scrolls the top edge of the selected result into view.

I didn't really try to reproduce the remaining problems you list.

marcella moved this task from To Triage to Freezer on the VisualEditor board.Jun 18 2019, 5:12 PM