[regression] Editor is read-only after recovering autosaved changes or switching VE to NWE
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	May 24 2019, 9:08 PM

Description

Editor is read-only after recovering autosaved changes.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/VisualEditor	wmf/1.34.0-wmf.6	+4 -0	Store 'canEdit' property when auto-saving or switching editors
	mediawiki/extensions/VisualEditor	master	+4 -0	Store 'canEdit' property when auto-saving or switching editors

Customize query in gerrit

Related Objects

Mentioned Here: rEVEDb9835f75d32a: Check if page is really editable and call #setReadOnly accordingly

Event Timeline

matmarex created this task.May 24 2019, 9:08 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptMay 24 2019, 9:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Caused by rEVEDb9835f75d32a: Check if page is really editable and call #setReadOnly accordingly

Also, when switching from VE to NWE, it is also read-only.

Change 512438 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Store 'canEdit' property when auto-saving or switching editors

https://gerrit.wikimedia.org/r/512438

gerritbot added a project: Patch-For-Review.May 24 2019, 9:16 PM

Looks like this made it into wmf.6… :/ we should backport on Monday.

matmarex triaged this task as Unbreak Now! priority.May 24 2019, 9:21 PM

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 24 2019, 9:21 PM

Change 512438 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Store 'canEdit' property when auto-saving or switching editors

https://gerrit.wikimedia.org/r/512438

Change 512448 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.6] Store 'canEdit' property when auto-saving or switching editors

https://gerrit.wikimedia.org/r/512448

Change 512448 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.6] Store 'canEdit' property when auto-saving or switching editors

https://gerrit.wikimedia.org/r/512448

Mentioned in SAL (#wikimedia-operations) [2019-05-25T00:30:20Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.6/extensions/VisualEditor/modules/ve-mw/init/ve.init.mw.ArticleTarget.js: Hot-deploy T224319 for VisualEditor switching and auto-restore (duration: 00m 50s)

Hot-deployed.

Jdforrester-WMF added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 25 2019, 12:43 AM

Jdforrester-WMF lowered the priority of this task from Unbreak Now! to High.May 25 2019, 1:50 AM

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.7; 2019-05-28); removed MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 25 2019, 4:01 AM

Ryasmeen added a project: Verified.May 25 2019, 6:53 AM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

Thanks! :o

ppelberg closed this task as Resolved.Jul 3 2019, 3:11 AM

[regression] Editor is read-only after recovering autosaved changes or switching VE to NWEClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[regression] Editor is read-only after recovering autosaved changes or switching VE to NWE
Closed, ResolvedPublic
Actions