Description

Motivation
As a developer working on Wikibase, I want to be able to fix javascript formatting issues in my code automatically in order to save time and unnecessary CI failures.

Suggested Solution
Using eslint's fix feature, introduce a new grunt task fix-js to run eslint --fix on javascript files.

For reference, WikibaseLexeme has a similar grunt task fix.. Check their Grunfile

Details

Related Gerrit Patches:

mediawiki/extensions/Wikibase : master

Configure 'grunt fix' task for eslint on Wikibase.git

Related Objects

Mentioned In: T228734: Hook automatically fixing js formatting issues into git precommit
T228665: Review tasks before story time

Event Timeline

noarave created this task.May 27 2019, 7:56 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2019, 7:56 AM

Addshore renamed this task from Configure 'grunt fix' task for eslint on Wikibase to Configure 'grunt fix' task for eslint on Wikibase.git.Jul 18 2019, 3:35 PM

Addshore triaged this task as Low priority.

Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.

• alaa_wmde mentioned this in T228665: Review tasks before story time.Jul 22 2019, 2:20 PM

• alaa_wmde added projects: Developer Productivity, good first task.Jul 23 2019, 9:15 AM

• alaa_wmde updated the task description. (Show Details)Jul 23 2019, 9:24 AM

• alaa_wmde mentioned this in T228734: Hook automatically fixing js formatting issues into git precommit.Jul 23 2019, 9:32 AM

• alaa_wmde set the point value for this task to 3.Jul 30 2019, 12:26 PM

• alaa_wmde moved this task from Ready to estimate to Ready to pick up on the Wikidata-Campsite board.

Rosalie_WMDE moved this task from Ready to pick up to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.Aug 2 2019, 11:44 AM

Rosalie_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

Rosalie_WMDE claimed this task.Aug 2 2019, 12:59 PM

Rosalie_WMDE moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Change 527534 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Configure 'grunt fix' task for eslint on Wikibase.git

https://gerrit.wikimedia.org/r/527534

gerritbot added a project: Patch-For-Review.Aug 2 2019, 1:03 PM

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Aug 2 2019, 1:06 PM

Change 527534 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Configure 'grunt fix' task for eslint on Wikibase.git

https://gerrit.wikimedia.org/r/527534

Rosalie_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Aug 6 2019, 9:13 AM

• alaa_wmde closed this task as Resolved.Aug 12 2019, 12:41 PM

• alaa_wmde moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.19; 2019-08-20).Aug 20 2019, 11:01 AM