Page MenuHomePhabricator

Configure 'grunt fix' task for eslint on Wikibase.git
Closed, ResolvedPublic3 Story Points

Description

Motivation
As a developer working on Wikibase, I want to be able to fix javascript formatting issues in my code automatically in order to save time and unnecessary CI failures.

Suggested Solution
Using eslint's fix feature, introduce a new grunt task fix-js to run eslint --fix on javascript files.

For reference, WikibaseLexeme has a similar grunt task fix.. Check their Grunfile

Event Timeline

noarave created this task.May 27 2019, 7:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2019, 7:56 AM
Addshore renamed this task from Configure 'grunt fix' task for eslint on Wikibase to Configure 'grunt fix' task for eslint on Wikibase.git.Jul 18 2019, 3:35 PM
Addshore triaged this task as Low priority.
Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
alaa_wmde updated the task description. (Show Details)Jul 23 2019, 9:24 AM
alaa_wmde set the point value for this task to 3.Jul 30 2019, 12:26 PM
alaa_wmde moved this task from Ready to estimate to Ready to pick up on the Wikidata-Campsite board.

Change 527534 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Configure 'grunt fix' task for eslint on Wikibase.git

https://gerrit.wikimedia.org/r/527534

Change 527534 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Configure 'grunt fix' task for eslint on Wikibase.git

https://gerrit.wikimedia.org/r/527534