Page MenuHomePhabricator

Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences
Open, Needs TriagePublic

Description

Hi everyone,

User:Patriccck reported to me by email that he sees Wikidata changes and categorization changes in Special:RecentChanges, even this isn't enabled in his preferences nor in new RC interface, see attached screenshot. I'm out of ideas, can somebody help, please?

Martin Urbanec

ptr2.png (757×1 px, 260 KB)

Note: added here a case from comments that illustrates the bug:
the option "Show wikidata edits" is not enabled and "Hide categorization" is enabled and no RC filters are selected, yet wikidata edits and changes in categories are still displayed e.g.
the following options selections

Screen Shot 2019-05-29 at 9.02.40 PM.png (297×516 px, 42 KB)

will result that RC page disregards these options entirely

Screen Shot 2019-05-29 at 9.03.19 PM.png (701×1 px, 362 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Has somebody some questions? I am the original reporter. Martin, thanks for creating this task.

Confirmed rcshowwikidata isn't enabled as a preference or a global preference

OOI, does turning it on and off again (saving in between, of course), fix it?

Ammarpad renamed this task from User:Patriccck sees Wikidata changes in Special:RecentChanges even not enabled in preferences to Wikidata changes show up in Special:RecentChanges even if not enabled in preferences.May 27 2019, 1:19 PM

@Ammarpad Well, I don't experience this problem, that's why the user-specific title.

Aklapper renamed this task from Wikidata changes show up in Special:RecentChanges even if not enabled in preferences to User:Patriccck sees Wikidata changes in Special:RecentChanges even not enabled in preferences.May 27 2019, 2:17 PM
Patriccck renamed this task from User:Patriccck sees Wikidata changes in Special:RecentChanges even not enabled in preferences to User:Patriccck sees Wikidata and categories changes in Special:RecentChanges even not enabled in preferences.EditedMay 27 2019, 4:40 PM

Confirmed rcshowwikidata isn't enabled as a preference or a global preference

OOI, does turning it on and off again (saving in between, of course), fix it?

No, I still see edits of categories and Wikidata. Btw. what is OOI?

Patriccck renamed this task from User:Patriccck sees Wikidata and categories changes in Special:RecentChanges even not enabled in preferences to User:Patriccck sees Wikidata changes and categorization changes in Special:RecentChanges even not enabled in preferences.May 27 2019, 4:44 PM

Confirmed rcshowwikidata isn't enabled as a preference or a global preference

OOI, does turning it on and off again (saving in between, of course), fix it?

No, I still see edits of categories and Wikidata. Btw. what is OOI?

Thanks for checking that. OOI is probably out of interest.

I can reproduce this.
Growth team: Is this possibly related to the new watchlist? Is there anyone who can help me dig into this more?

Urbanecm renamed this task from User:Patriccck sees Wikidata changes and categorization changes in Special:RecentChanges even not enabled in preferences to Some userssee Wikidata changes and categorization changes in Special:RecentChanges even not enabled in preferences.May 28 2019, 9:16 AM

I can reproduce this.
Growth team: Is this possibly related to the new watchlist? Is there anyone who can help me dig into this more?

Thank you Lydia. Renamed to reflect reality.

Urbanecm renamed this task from Some userssee Wikidata changes and categorization changes in Special:RecentChanges even not enabled in preferences to Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences.May 28 2019, 9:20 AM

And one more rename, I forgot I have filters to display only unpatrolled edits, which doesn't include WD edits. So, can reproduce it too.

JTannerWMF subscribed.

The Growth team will look into this task and plan to work on this based on our investigation.

Selection of Preferences-Recent changes options applies only to default filter set on Recent changes. Selecting the option - 'Hide Wikidata' will not hide the filter wikidata, or wikidata entries if they will come in the result set of other filter selection.

For example, if I select in Preferences-Recent Changes the following options

  • Show Wikidata edits in recent changes
  • Hide minor edits from recent changes
  • Hide categorization of pages
  • Highlight likely problem edits with colors and an "r" for "needs review"
  • Show only likely problem edits (and hide probably good edits)

Screen Shot 2019-05-29 at 9.05.10 AM.png (581×804 px, 89 KB)

And then I go to Recent changes, I'll see the following filters defined as default filter set (the true default filters - without user selecting options - are in red circles).

Screen Shot 2019-05-29 at 8.58.26 AM.png (171×1 px, 64 KB)

If I did not click the option "Show Wikidata edits in recent changes" - Wikidata edits still be shown as result of applying other filters - Humans(not bots) or ORES filters. The present logic for filters does not work as "show me edits by humans but exclude Wikidata edits".

@Etonkovidova Hi, I can see "Wikidata edits" in your second screenshot. However, in the screenshot from task's description (F29258444), there's nothing saying "Wikidata". I understand that the filters understands "Wikidata edit" as "human edit", even that, I think preferences should be honored, unless explicitly overriden by adding "Wikidata edits" to display, as in your screenshot.

@Urbanecm

@Etonkovidova Hi, I can see "Wikidata edits" in your second screenshot. However, in the screenshot from task's description (F29258444), there's nothing saying "Wikidata". I understand that the filters understands "Wikidata edit" as "human edit", even that, I think preferences should be honored, unless explicitly overriden by adding "Wikidata edits" to display, as in your screenshot.

My screenshot illustrates only the point that selecting the option "Show wikidata edits" option in Preferences-Recent changes will include Wikidata filter in default filters - nothing more.

In the task description screenshot - wikidata entries appear because Human(non bot) filter was selected and Wikidata edits were made by humans, as you mentioned in the comment above.

I agree that "Show wikidata edits" when not enabled should exclude wikidata edits entirely from all filters' result set. Two other options "Hide categorization of pages" and "Hide minor edits from recent changes" behave the same as "Show wikidata edits".
The real bug is actually there - the option "Show wikidata edits" is not enabled and "Hide categorization" is enabled and no RC filters are selected, yet wikidata edits and changes in categories are still displayed e.g.
the following options selections

Screen Shot 2019-05-29 at 9.02.40 PM.png (297×516 px, 42 KB)

will result that RC page disregards these options entirely

Screen Shot 2019-05-29 at 9.03.19 PM.png (701×1 px, 362 KB)

After help (using e-mail) from @Urbanecm, I don't see Wikidata & categorization edits. Thanks!

After help (using e-mail) from @Urbanecm, I don't see Wikidata & categorization edits. Thanks!

@Patriccck - did you find some workaround for specific filter set you're using?

The workaround was to add "edited pages", "logged actions" and "created pages" to his filterset.

The workaround was to add "edited pages", "logged actions" and "created pages" to his filterset.

Thx! Yes, these filters are default filters and it works for the specific situation (since wikidata edits are not classified as Page creation, Page edits, or Logged entries). In my opinion, the more general issue with making the logic clearer for "Show wikidata edits" and other Preferences-RC options still needs to be re-evaluated.

The workaround was to add "edited pages", "logged actions" and "created pages" to his filterset.

Thx! Yes, these filters are default filters and it works for the specific situation (since wikidata edits are not classified as Page creation, Page edits, or Logged entries). In my opinion, the more general issue with making the logic clearer for "Show wikidata edits" and other Preferences-RC options still needs to be re-evaluated.

I think it too.

The preference is labeled "Show Wikidata edits *by default* in recent changes". If you don't have it enabled, the default state of the RC filters when you open RC will be such that Wikidata edits aren't shown, but if you then change the filters they may end up being shown. I'm not sure how we could make this clearer.

What is a bit confusing is that the way that this excludes Wikidata edits is by filtering for everything else (Page creations, Page edits, Log actions, etc), because the interface always tells you what it is showing (not what it isn't showing). If you remove these filters, all types of changes will be shown, including Wikidata edits, and that confuses some people. But I don't think there's much to do here, unless there are relatively simple ways to clarify this.

JTannerWMF added a project: UX-Debt.

The Growth-Team will revisit this task sometime this fiscal year.

Catrope unsubscribed.