Description

When transferring template content across languages, Content translation can face two different issues:

Missing template (T192271): not finding the corresponding template.
Incomplete template (T209473): finding the template but being unable to map the parameters to copy the information over.

These are different issues with different messages. However, I've found cases where an incomplete template adaptation is reported as missing. For example, translating Pont vell de Vilaller from Catalan to English, the infobox is added as "Infobox building" to the translation with their parameters empty (incomplete template case), but the warning shown indicates it is missing instead. This quick link allows testing with a minimal example.

Screenshot 2019-05-27 at 19.22.23.png (671×1 px, 298 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Set missing template warning only if template does not exist in target language	mediawiki/extensions/ContentTranslation	master	+1 -9

Customize query in gerrit

Related Objects

Mentioned In: T225716: Reference marked as missing but successfully adapted
T209473: CX2: Communicate template exists in the target wiki but mapping could not be completed
T203160: CX2: Highlight (and skip) references with a template that could not be adapted
T204937: CX2: Don't add block templates to the translation if equivalent template is missing
Mentioned Here: T192271: CX2: Communicate template could not be adapted
T209473: CX2: Communicate template exists in the target wiki but mapping could not be completed

Event Timeline

Pginer-WMF created this task.May 27 2019, 5:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2019, 5:19 PM

Pginer-WMF triaged this task as Medium priority.May 27 2019, 5:25 PM

Pginer-WMF updated the task description. (Show Details)

Pginer-WMF mentioned this in T204937: CX2: Don't add block templates to the translation if equivalent template is missing.May 27 2019, 5:27 PM

Pginer-WMF mentioned this in T203160: CX2: Highlight (and skip) references with a template that could not be adapted.

Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2019-April-June) board.Jun 3 2019, 3:48 PM

• Petar.petkovic claimed this task.Jun 13 2019, 8:04 AM

• Petar.petkovic moved this task from Priority backlog to In Progress on the Language-Team (Language-2019-April-June) board.Jun 13 2019, 8:08 AM

Change 516969 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Set missing template warning only if template does not exist in target language

https://gerrit.wikimedia.org/r/516969

gerritbot added a project: Patch-For-Review.Jun 13 2019, 10:50 PM

• Petar.petkovic moved this task from In Progress to In Review on the Language-Team (Language-2019-April-June) board.Jun 13 2019, 10:51 PM

• Petar.petkovic moved this task from Needs Triage to Bugs on the ContentTranslation board.

I have uploaded the patch that should show missing template warning only when template is really missing. Previously it could also be shown when no params are adapted.

@Pginer-WMF, it is important to know that incomplete template warning is never shown and T209473 was resolved too early. The infrastructure to show such message was added to cxserver, but never utilized to actually show warning on CX frontend.

In T224437#5258003, @Petar.petkovic wrote:

@Pginer-WMF, it is important to know that incomplete template warning is never shown and T209473 was resolved too early. The infrastructure to show such message was added to cxserver, but never utilized to actually show warning on CX frontend.

Thanks Petar. I reopened the ticket.

Pginer-WMF mentioned this in T225716: Reference marked as missing but successfully adapted.Jun 19 2019, 7:58 AM

Pginer-WMF edited projects, added Language-Team (Language-2019-July-September); removed Language-Team (Language-2019-April-June).Jul 1 2019, 12:27 PM

Pginer-WMF moved this task from Backlog to In Review on the Language-Team (Language-2019-July-September) board.Jul 1 2019, 12:29 PM

Change 516969 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Set missing template warning only if template does not exist in target language

https://gerrit.wikimedia.org/r/516969

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 1 2019, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 1 2019, 4:10 PM

• Petar.petkovic moved this task from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.Jul 1 2019, 4:56 PM