Page MenuHomePhabricator

Incomplete template adaptation presented as missing
Closed, ResolvedPublic

Description

When transferring template content across languages, Content translation can face two different issues:

  • Missing template (T192271): not finding the corresponding template.
  • Incomplete template (T209473): finding the template but being unable to map the parameters to copy the information over.

These are different issues with different messages. However, I've found cases where an incomplete template adaptation is reported as missing. For example, translating Pont vell de Vilaller from Catalan to English, the infobox is added as "Infobox building" to the translation with their parameters empty (incomplete template case), but the warning shown indicates it is missing instead. This quick link allows testing with a minimal example.

Details

Related Gerrit Patches:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2019, 5:19 PM
Pginer-WMF triaged this task as Medium priority.May 27 2019, 5:25 PM
Pginer-WMF updated the task description. (Show Details)

Change 516969 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Set missing template warning only if template does not exist in target language

https://gerrit.wikimedia.org/r/516969

I have uploaded the patch that should show missing template warning only when template is really missing. Previously it could also be shown when no params are adapted.

@Pginer-WMF, it is important to know that incomplete template warning is never shown and T209473 was resolved too early. The infrastructure to show such message was added to cxserver, but never utilized to actually show warning on CX frontend.

@Pginer-WMF, it is important to know that incomplete template warning is never shown and T209473 was resolved too early. The infrastructure to show such message was added to cxserver, but never utilized to actually show warning on CX frontend.

Thanks Petar. I reopened the ticket.

Change 516969 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Set missing template warning only if template does not exist in target language

https://gerrit.wikimedia.org/r/516969

Jpita added a subscriber: Jpita.

checked in cx2-testing

Jpita closed this task as Resolved.Jul 16 2019, 11:28 AM